Skip to content

feat: add internal thinking field to capture model's reasoning output #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ilopezluna wants to merge 1 commit into
base: support-multimodal
Choose a base branch
from
+11 −1
Open

feat: add internal thinking field to capture model's reasoning output #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/ollama/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ type Message struct {
Images []string `json:"images,omitempty"` // For multimodal support
ToolCalls []ToolCall `json:"tool_calls,omitempty"` // For function calling
ToolCallID string `json:"tool_call_id,omitempty"` // For tool results
Thinking string `json:"thinking,omitempty"` // Internal field for model's thinking output
}

// ToolCall represents a function call made by the model
Expand Down
11 changes: 10 additions & 1 deletion pkg/ollama/http_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,11 +1056,13 @@ func (s *streamingChatResponseWriter) Write(data []byte) (int, error) {
continue
}

// Extract content and tool calls from structured response
// Extract content, tool calls, and thinking from structured response
var content string
var thinking string
var toolCalls []ToolCall
if len(chunk.Choices) > 0 {
content = chunk.Choices[0].Delta.Content
thinking = chunk.Choices[0].Delta.ReasoningContent
if len(chunk.Choices[0].Delta.ToolCalls) > 0 {
// Convert tool calls to Ollama format
toolCalls = convertToolCallsToOllamaFormat(chunk.Choices[0].Delta.ToolCalls)
Expand All @@ -1075,6 +1077,9 @@ func (s *streamingChatResponseWriter) Write(data []byte) (int, error) {
if len(toolCalls) > 0 {
message.ToolCalls = toolCalls
}
if thinking != "" {
message.Thinking = thinking
}

ollamaChunk := ChatResponse{
Model: s.modelName,
Expand Down Expand Up @@ -1242,6 +1247,10 @@ func (h *HTTPHandler) convertChatResponse(w http.ResponseWriter, respRecorder *r
if len(openAIResp.Choices[0].Message.ToolCalls) > 0 {
message.ToolCalls = convertToolCallsToOllamaFormat(openAIResp.Choices[0].Message.ToolCalls)
}
// Include thinking content if present
if openAIResp.Choices[0].Message.ReasoningContent != "" {
message.Thinking = openAIResp.Choices[0].Message.ReasoningContent
}
}

// Build Ollama response
Expand Down