Skip to content

fix: edit link/button leads to 404 - #729

Merged
AlexanderLanin merged 3 commits into
eclipse-score:mainfrom
bgsw-contrib:EditLink_fix
Aug 20, 2026
Merged

fix: edit link/button leads to 404#729
AlexanderLanin merged 3 commits into
eclipse-score:mainfrom
bgsw-contrib:EditLink_fix

Conversation

@kirankumar-H-V

@kirankumar-H-V kirankumar-H-V commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

📌 Description

Fixes the broken Edit on GitHub link (404) by ensuring doc_path is repo-relative, not an absolute CI runner path.

Updated edit-link path handling in incremental docs build.
Added regression tests for root package, nested package, and no absolute path leakage.
resolves #706

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 8319879a-057a-475d-92eb-8ea550956780
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
WARNING: Target pattern parsing failed.
ERROR: Skipping '//src:license-check': no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
ERROR: no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
INFO: Elapsed time: 6.209s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

a-zw
a-zw previously requested changes Aug 19, 2026
Comment thread src/incremental.py Outdated
@kirankumar-H-V
kirankumar-H-V requested a review from a-zw August 20, 2026 10:54
@kirankumar-H-V

kirankumar-H-V commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

As requested by @a-zw as a review point : code been refactored according to the review comments, relevant test are removed.

@github-actions

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-729: https://eclipse-score.github.io/docs-as-code/pr-729/

@AlexanderLanin
AlexanderLanin dismissed a-zw’s stale review August 20, 2026 20:43

findings addressed and fixed

@AlexanderLanin

Copy link
Copy Markdown
Member

Thanks for the fix @kirankumar-H-V !

@AlexanderLanin AlexanderLanin changed the title bug: #706 edit link/button leads to 404 fix: edit link/button leads to 404 Aug 20, 2026
@AlexanderLanin
AlexanderLanin merged commit ae829d2 into eclipse-score:main Aug 20, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

bug: edit link/button leads to 404

3 participants