fix: edit link/button leads to 404 - #729
Merged
Merged
Conversation
kirankumar-H-V
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
a-zw,
dcalavrezo-qorix and
nradakovic
as code owners
August 19, 2026 12:45
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
a-zw
previously requested changes
Aug 19, 2026
Contributor
Author
|
As requested by @a-zw as a review point : code been refactored according to the review comments, relevant test are removed. |
Contributor
|
Documentation preview for this pull request is available at: |
AlexanderLanin
approved these changes
Aug 20, 2026
Member
|
Thanks for the fix @kirankumar-H-V ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Fixes the broken Edit on GitHub link (404) by ensuring doc_path is repo-relative, not an absolute CI runner path.
Updated edit-link path handling in incremental docs build.
Added regression tests for root package, nested package, and no absolute path leakage.
resolves #706
🚨 Impact Analysis
✅ Checklist