Skip to content

fix: edit link/button leads to 404 #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexanderLanin merged 3 commits into from
Aug 20, 2026
Merged

fix: edit link/button leads to 404 #729

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6715ca
bug: #706 edit link/button leads to 404
kirankumar-H-V Aug 19, 2026
2131ecb
bug: #706 edit link/button leads to 404 Review comments taken care of
kirankumar-H-V Aug 20, 2026
2ebbde4
bug: #706 edit link/button leads to 404 : Review comments taken care
kirankumar-H-V Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/incremental.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,10 @@ def _mounted_watch_dirs(
base_arguments.append(f"-A=github_user={github_user}")
base_arguments.append(f"-A=github_repo={github_repo}")
base_arguments.append("-A=github_version=main")
base_arguments.append(f"-A=doc_path={package_dir / source_directory}")
# doc_path must be repo-relative so the edit URL does not contain the
# absolute runner filesystem path (e.g. /home/runner/work/…/docs).
relative_doc_path = Path(os.environ.get("PACKAGE_DIR", "")) / source_directory
base_arguments.append(f"-A=doc_path={relative_doc_path}")

if os.getenv("KNOWN_GOOD_JSON"):
base_arguments.append(f"--define=KNOWN_GOOD_JSON={get_env('KNOWN_GOOD_JSON')}")
Expand Down
Loading