Skip to content

upgrade_adapter/3 runs before_send callbacks#1309

Merged
josevalim merged 1 commit into
elixir-plug:mainfrom
nixxquality:upgrade_adapter/3-before_send
Jun 12, 2026
Merged

upgrade_adapter/3 runs before_send callbacks#1309
josevalim merged 1 commit into
elixir-plug:mainfrom
nixxquality:upgrade_adapter/3-before_send

Conversation

@nixxquality

Copy link
Copy Markdown
Contributor

We should change [upgrade_adapter] to call the callback on :upgrade too. We already call it when :chunked and in other scenarios, so it is already the user's responsibility to check the state is something they can deal with. PRs welcome.

Fixes #1308.

@josevalim josevalim merged commit 041bb1b into elixir-plug:main Jun 12, 2026
2 checks passed
@josevalim

Copy link
Copy Markdown
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

An alternative to Plug.Conn.register_before_send/2 which works for upgraded connections

2 participants