Skip to content

upgrade_adapter/3 runs before_send callbacks #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Jun 12, 2026
+11 −1
Merged

upgrade_adapter/3 runs before_send callbacks #1309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/plug/conn.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1469,7 +1469,8 @@ defmodule Plug.Conn do
when state in @unsent do
case adapter.upgrade(payload, protocol, args) do
{:ok, payload} ->
%{conn | adapter: {adapter, payload}, state: :upgraded}
conn = run_before_send(conn, :upgraded)
%{conn | adapter: {adapter, payload}}

{:error, :not_supported} ->
raise ArgumentError, "upgrade to #{protocol} not supported by #{inspect(adapter)}"
Expand Down
9 changes: 9 additions & 0 deletions test/plug/conn_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,15 @@ defmodule Plug.ConnTest do
end)
end

test "upgrade_adapter/3 runs before_send callbacks" do
conn =
conn(:get, "/foo")
|> register_before_send(&assign(&1, :ran_before_send, true))
|> upgrade_adapter(:supported, opt: :supported)

assert conn.assigns[:ran_before_send] == true
end

test "chunk/2 raises if send_chunked/3 hasn't been called yet" do
conn = conn(:get, "/")

Expand Down