Skip to content

Comments

Altering champ combat game to make changing sprites more important#1950

Open
izzykriz wants to merge 7 commits intomainfrom
champ-combat-identical-sprites
Open

Altering champ combat game to make changing sprites more important#1950
izzykriz wants to merge 7 commits intomainfrom
champ-combat-identical-sprites

Conversation

@izzykriz
Copy link
Contributor

Since changing the bait sprites is so avoidable in the combat minigame, altered it so that the sprites are very difficult to tell apart at first, and encourages the players to edit the sprite pngs so they can easily distinguish them.

@izzykriz izzykriz requested review from a team as code owners February 19, 2026 18:00
@github-actions
Copy link

Play this branch at https://play.threadbare.game/branches/endlessm/champ-combat-identical-sprites.

(This launches the game from the start, not directly at the change(s) in this pull request.)

@Fauche-r Fauche-r linked an issue Feb 19, 2026 that may be closed by this pull request
Copy link
Contributor

@Fauche-r Fauche-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the change provided, and with the way it was done, I would wait for @shadeydo and @felixwalberg's input, as I'm not sure if it also fit their vision.

Copy link
Contributor

@felixwalberg felixwalberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great! The closeness of the dull colors makes it difficult for me to determine which target the bait is associated with. I'm sure this will provide extra motivation for the learners. The only change I made was adding the HitSound of the projectile scenes back to the SFX bus (my understanding is that this is managed globally in Threadbare and will ensure it is mixed properly with the other audio).

One other thing I will mention is that the dialogue prompt "color in the champ_bait_projectile pngs" can also be addressed by learners with the Modulate attribute of the AnimatedSprite2D node of the projectile via the inspector. This allows them to change the color of the entire png without having to leave Godot. If they want to get more creative, as your dialogue encourages, they can replace the entire sprite!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Champ: Increase importance of editing sprites for combat scene

3 participants