Repository navigation
build: fixture-distinct-c-symbols - #919
Conversation
The two fixture packages both defined a weak fixture_answer, so either C source satisfied both plugins. The C and Zig sources are now templates and check-examples.sh names the symbol after the package id, non-weak. Agent-Team: macos Worker: claude
PM note: how this PR will be handledWhat it is for: build: fixture-distinct-c-symbols Rules that apply: none special. Things to watch (checked by rule):
What happens next:
A living status comment below is kept current. Nothing here is a merge decision. |
Where this PR standsStage: Done: approved What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):
Reviews at the current commit (
Updated 2026-10-27 20:58 UTC by the PM. This comment is edited in place. |
Part of fizzyedit/work#462
Goal
Each build-API fixture package gets a distinct, non-weak C symbol so the C-dependency fixture fails if either package's C source is missing (work#462, #879 follow-up).
What changed and why
lib.candlib.zigbecamelib.c.tmpl/lib.zig.tmplwith@ID@;scripts/check-examples.shrenders them per package (fixture_both_answer,fixture_native_answer).plugin.zigcallsfixture_lib.answer().How it was verified
scripts/check-fmt.sh;EXAMPLES_BUILDS="" scripts/check-examples.shpasses. With the script temporarily emptying either package'slib.c, the fixture app fails to build (run once per package); restored after.Not done / follow-ups
Other repo gates not run (no Zig source under app/sdk/src touched).
scripts/zb build testfails here infizzy-remote-tests(client_tests/capi: 1 fail, 7 crash, socket tests), a sandbox-side failure in code this change does not touch;agent-finishtherefore stopped at that gate. Needs CI to confirm.Changes (6 files, +15/-9)
Gates: not run yet
Gates not run yet;
scripts/agent-finish 462replaces this with their output.