Conversation
There was a problem hiding this comment.
don't think there are any of these, but for the sake of completeness may as well
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
spalmurray
force-pushed
the
spalmurray/remove-jira-dead-code
branch
from
0c43f58 to
e10f9c7
Compare
|
Note that we should delay until the jira inc migration is complete because we can then remove the domain and redirect as well. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| @deserialize | ||
| class JIRAConfig: | ||
| domain: str | ||
| account: str |
There was a problem hiding this comment.
Config files have stale fields removed from JIRAConfig
Medium Severity
The JIRAConfig class had account, api_key, and severity_field removed, but config.ci.toml (used by CI via CONFIG_FILE_PATH) and config.example.toml still define those fields under [jira]. If pyserde's from_toml raises on unknown fields, backend test CI would break. Even if pyserde silently ignores them, the config files now contain stale fields that don't match JIRAConfig and could confuse developers setting up the project.
2 participants
This stuff is back from when we were going to read from jira for the initial firetower MVP. We have since moved away from that and this code is not needed anymore.