-
-
Notifications
You must be signed in to change notification settings - Fork 0
chore: Clean up dead jira code #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
2f9fb62
56e8e7e
c2e9c44
fc3cef6
e10f9c7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,9 +29,6 @@ class DatadogConfig: | |
| @deserialize | ||
| class JIRAConfig: | ||
| domain: str | ||
| account: str | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Config files have stale fields removed from JIRAConfigMedium Severity The |
||
| api_key: str | ||
| severity_field: str | ||
|
|
||
|
|
||
| @deserialize | ||
|
|
@@ -108,9 +105,6 @@ def __init__(self) -> None: | |
| ) | ||
| self.jira = JIRAConfig( | ||
| domain="", | ||
| account="", | ||
| api_key="", | ||
| severity_field="", | ||
| ) | ||
| self.slack = SlackConfig( | ||
| bot_token="", | ||
|
|
||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. don't think there are any of these, but for the sake of completeness may as well |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| from django.db import migrations, models | ||
|
|
||
|
|
||
| def delete_jira_links(apps, schema_editor): | ||
| ExternalLink = apps.get_model("incidents", "ExternalLink") | ||
| ExternalLink.objects.filter(type="JIRA").delete() | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): | ||
| dependencies = [ | ||
| ("incidents", "0014_add_total_downtime"), | ||
| ] | ||
|
|
||
| operations = [ | ||
| migrations.RunPython(delete_jira_links, migrations.RunPython.noop), | ||
| migrations.AlterField( | ||
| model_name="externallink", | ||
| name="type", | ||
| field=models.CharField( | ||
| choices=[ | ||
| ("SLACK", "Slack"), | ||
| ("DATADOG", "Datadog"), | ||
| ("PAGERDUTY", "PagerDuty"), | ||
| ("STATUSPAGE", "Statuspage"), | ||
| ("NOTION", "Notion"), | ||
| ("LINEAR", "Linear"), | ||
| ], | ||
| max_length=20, | ||
| ), | ||
| ), | ||
| ] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| """Services package for external integrations.""" | ||
|
|
||
| from .jira import JiraService | ||
| from .slack import SlackService | ||
|
|
||
| __all__ = ["JiraService", "SlackService"] | ||
| __all__ = ["SlackService"] | ||
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file was deleted.


Uh oh!
There was an error while loading. Please reload this page.