Testing for v2.10.0

[JoyceZhu]

No description provided.

[Copilot]

Pull request overview

Updates the accessibility-scanner action stack for the v2.10.0 release by bumping JS/TS toolchain and action dependencies, and by adding Playwright context configuration inputs to influence scan rendering.

Changes:

• Bump repo and sub-action dependencies (notably @actions/core v3, Playwright, and ESLint/types tooling) and refresh lockfiles.
• Add reduced_motion and color_scheme inputs (root action + find action) and wire them into Playwright browser context creation.
• Refresh action bootstraps and CI lint workflow Node setup action version.

Reviewed changes

Copilot reviewed 19 out of 25 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
package.json	Dev dependency bumps (Node types, ESLint, typescript-eslint).
package-lock.json	Lockfile refresh to match updated root dependencies.
action.yml	Adds new top-level inputs and passes them through to find.
README.md	Documents new inputs and fixes heading formatting.
.github/workflows/lint.yml	Updates actions/setup-node major version.
.github/actions/fix/src/index.ts	Switches @actions/core import style for v3 compatibility.
.github/actions/fix/package.json	Bumps @actions/core and @types/node.
.github/actions/fix/package-lock.json	Lockfile refresh for fix action dependency bumps.
.github/actions/fix/bootstrap.js	Improves bootstrap logging/error reporting and formatting.
.github/actions/find/src/types.d.ts	Introduces types for reduced motion / color scheme preferences.
.github/actions/find/src/index.ts	Parses/validates new inputs and passes them into scanning.
.github/actions/find/src/findForUrl.ts	Applies new options to Playwright browser.newContext.
.github/actions/find/package.json	Bumps @actions/core, @axe-core/playwright, and Playwright.
.github/actions/find/package-lock.json	Lockfile refresh for find action dependency bumps.
.github/actions/find/bootstrap.js	Improves bootstrap logging/error reporting and formatting.
.github/actions/find/action.yml	Adds new inputs to the find action definition.
.github/actions/find/README.md	Documents the two new find inputs.
.github/actions/file/src/index.ts	Switches @actions/core import style for v3 compatibility.
.github/actions/file/package.json	Bumps @actions/core and @types/node.
.github/actions/file/package-lock.json	Lockfile refresh for file action dependency bumps.
.github/actions/file/bootstrap.js	Improves bootstrap logging/error reporting and formatting.
.github/actions/auth/src/index.ts	Switches @actions/core import style for v3 compatibility.
.github/actions/auth/package.json	Bumps @actions/core, Playwright, and @types/node.
.github/actions/auth/package-lock.json	Lockfile refresh for auth action dependency bumps.
.github/actions/auth/bootstrap.js	Improves bootstrap logging/error reporting and formatting.

Files not reviewed (4)

• .github/actions/auth/package-lock.json: Language not supported
• .github/actions/file/package-lock.json: Language not supported
• .github/actions/find/package-lock.json: Language not supported
• .github/actions/fix/package-lock.json: Language not supported

Comments suppressed due to low confidence (1)

.github/actions/find/src/index.ts:33

• Same issue as reduced_motion: null in the allowlist cannot match core.getInput() output, so the code advertises support for null but cannot accept it. Align the allowlist/type with the real string inputs you expect (e.g. light|dark|no-preference) or handle the literal "null" explicitly.

  const colorSchemeInput = core.getInput('color_scheme', {required: false})
  let colorScheme: ColorSchemePreference | undefined
  if (colorSchemeInput) {
    if (!['light', 'dark', 'no-preference', null].includes(colorSchemeInput)) {
      throw new Error(
        "Input 'color_scheme' must be one of: 'light', 'dark', 'no-preference', or null per Playwright documentation.",
      )
    }
    colorScheme = colorSchemeInput as ColorSchemePreference
  }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

fs.accessSync is synchronous; awaiting it is misleading. Consider removing await (or using fs.promises.access) for clarity.

Suggested change

	await fs.accessSync(url.fileURLToPath(new URL('./node_modules', import.meta.url)), fs.constants.R_OK)
	fs.accessSync(url.fileURLToPath(new URL('./node_modules', import.meta.url)), fs.constants.R_OK)

[Copilot]

fs.accessSync is synchronous; await has no effect here and can confuse readers. Remove await or use the async fs.promises.access.

Suggested change

	await fs.accessSync(url.fileURLToPath(new URL('./node_modules', import.meta.url)), fs.constants.R_OK)
	await fs.promises.access(url.fileURLToPath(new URL('./node_modules', import.meta.url)), fs.constants.R_OK)

[Copilot]

core.getInput() always returns a string (or empty string), so including null in the allowed-values array will never validate as intended. As written, the error message claims null is allowed, but users cannot provide a real null and the literal string "null" will be rejected. Consider removing null from the accepted values/type, or explicitly accept the string "null" and map it to undefined/null before passing to Playwright, and prefer reporting via core.setFailed for consistent action failure output.

This issue also appears on line 24 of the same file.

Suggested change

	if (!['reduce', 'no-preference', null].includes(reducedMotionInput)) {
	throw new Error(
	"Input 'reduced_motion' must be one of: 'reduce', 'no-preference', or null per Playwright documentation.",
	)
	}
	reducedMotion = reducedMotionInput as ReducedMotionPreference
	}
	const colorSchemeInput = core.getInput('color_scheme', {required: false})
	let colorScheme: ColorSchemePreference | undefined
	if (colorSchemeInput) {
	if (!['light', 'dark', 'no-preference', null].includes(colorSchemeInput)) {
	throw new Error(
	"Input 'color_scheme' must be one of: 'light', 'dark', 'no-preference', or null per Playwright documentation.",
	)
	if (!['reduce', 'no-preference'].includes(reducedMotionInput)) {
	core.setFailed("Input 'reduced_motion' must be one of: 'reduce' or 'no-preference' per Playwright documentation.")
	return
	}
	reducedMotion = reducedMotionInput as ReducedMotionPreference
	}
	const colorSchemeInput = core.getInput('color_scheme', {required: false})
	let colorScheme: ColorSchemePreference | undefined
	if (colorSchemeInput) {
	if (!['light', 'dark', 'no-preference'].includes(colorSchemeInput)) {
	core.setFailed(
	"Input 'color_scheme' must be one of: 'light', 'dark', or 'no-preference' per Playwright documentation.",
	)
	return

[Copilot]

These input preference types include null, but GitHub Action inputs are strings and the current parsing/validation in src/index.ts can't produce null. Consider removing null from these unions (and treating absence as undefined) or adding explicit parsing to support a string sentinel like "null".

Suggested change

	export type ReducedMotionPreference = 'reduce' | 'no-preference' | null
	export type ColorSchemePreference = 'light' | 'dark' | 'no-preference' | null
	export type ReducedMotionPreference = 'reduce' | 'no-preference'
	export type ColorSchemePreference = 'light' | 'dark' | 'no-preference'

[Copilot]

The reduced_motion input description links to the browser.newPage option docs, but this value is used as a browser.newContext option in the code. Update the URL to the browser.newContext reducedMotion docs to avoid confusing users.

Suggested change

	description: "Playwright reducedMotion setting: https://playwright.dev/docs/api/class-browser#browser-new-page-option-reduced-motion"
	description: "Playwright reducedMotion setting: https://playwright.dev/docs/api/class-browser#browser-new-context-option-reduced-motion"

[Copilot]

The reduced_motion input description links to the browser.newPage option docs, but the action applies this value to browser.newContext options. Please update the documentation link/wording so it matches the actual usage.

Suggested change

	description: "Playwright reducedMotion setting: https://playwright.dev/docs/api/class-browser#browser-new-page-option-reduced-motion"
	description: "Playwright reducedMotion setting: https://playwright.dev/docs/api/class-browser#browser-new-context-option-reduced-motion"

[Copilot]

fs.accessSync is synchronous and does not return a promise, so await fs.accessSync(...) is misleading. Drop the await (or switch to fs.promises.access) to make the intent clearer.

Suggested change

	await fs.accessSync(url.fileURLToPath(new URL('./node_modules', import.meta.url)), fs.constants.R_OK)
	await fs.promises.access(url.fileURLToPath(new URL('./node_modules', import.meta.url)), fs.constants.R_OK)

[Copilot]

fs.accessSync is synchronous, so await fs.accessSync(...) is misleading. Remove the await (or switch to fs.promises.access).

Suggested change

	await fs.accessSync(url.fileURLToPath(new URL('./node_modules', import.meta.url)), fs.constants.R_OK)
	await fs.promises.access(url.fileURLToPath(new URL('./node_modules', import.meta.url)), fs.constants.R_OK)

[Copilot]

reducedMotion/colorScheme are conditionally spread based on truthiness. That makes the declared ... | null types misleading because null would be dropped here anyway. Prefer checking for undefined/empty input explicitly (or remove null from the types upstream) so the behavior matches the types and documented allowed values.

Suggested change

	...(reducedMotion ? {reducedMotion} : {}),
	...(colorScheme ? {colorScheme} : {}),
	...(reducedMotion !== undefined ? {reducedMotion} : {}),
	...(colorScheme !== undefined ? {colorScheme} : {}),

[github-advanced-security]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.