-
Notifications
You must be signed in to change notification settings - Fork 21
Testing for v2.10.0 #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JoyceZhu
wants to merge
38
commits into
v2
Choose a base branch
from
main
base: v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Testing for v2.10.0 #148
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
d895789
chore(deps): Bump @actions/core in /.github/actions/auth
dependabot[bot] 0587393
Merge branch 'main' into dependabot/npm_and_yarn/dot-github/actions/a…
JoyceZhu b33743b
chore(deps): Bump @actions/core in /.github/actions/fix
dependabot[bot] 775960a
chore(deps): Bump @actions/core in /.github/actions/find
dependabot[bot] 68ae0bf
Merge branch 'main' into dependabot/npm_and_yarn/dot-github/actions/f…
JoyceZhu 1cb7ec3
chore: Re-run checks, where smockle is the last pusher
smockle 762aeae
Merge branch 'main' into dependabot/npm_and_yarn/dot-github/actions/f…
smockle d92c97d
chore(deps): Bump actions/setup-node
dependabot[bot] 686453b
chore(deps): Bump @actions/core in /.github/actions/file
dependabot[bot] b534ea8
chore(deps): Bump actions/setup-node from 4 to 6 in the github-action…
JoyceZhu 975bb4a
Merge branch 'main' into dependabot/npm_and_yarn/dot-github/actions/a…
JoyceZhu ef69aa1
Fix import for ESM
JoyceZhu 43dc21d
Fix `actions/core` import for ESM
JoyceZhu 208e090
Fix `actions/core` import for ESM
JoyceZhu 9339153
Fix `actions/core` import for ESM
JoyceZhu eb07bbb
chore(deps): Bump @actions/core from 2.0.1 to 3.0.0 in /.github/actio…
JoyceZhu cc8650e
Merge branch 'main' into dependabot/npm_and_yarn/dot-github/actions/f…
JoyceZhu b666418
chore(deps): Bump @actions/core from 2.0.1 to 3.0.0 in /.github/actio…
JoyceZhu c855430
Merge branch 'main' into dependabot/npm_and_yarn/dot-github/actions/f…
JoyceZhu cc39faf
chore(deps): Bump @actions/core from 2.0.1 to 3.0.0 in /.github/actio…
JoyceZhu 75fea76
chore(deps): Bump the npm-minor-and-patch group across 5 directories …
dependabot[bot] 71774c8
Add more error logging to Actions
JoyceZhu f2a4985
chore(deps): Bump @actions/core from 2.0.1 to 3.0.0 in /.github/actio…
JoyceZhu 7666317
Merge branch 'main' into joyce/add_more_error_logging_to_Actions
JoyceZhu 60fa503
Fix mistaken `console.error`
JoyceZhu b665f80
Update aXe import
JoyceZhu 3fc822d
chore(deps): Bump the npm-minor-and-patch group across 5 directories …
JoyceZhu c869886
Dynamically import `actions/core` after `ci`
JoyceZhu 584eedd
Merge branch 'main' into joyce/add_more_error_logging_to_Actions
JoyceZhu 066e45c
Add more error logging to Actions (#143)
JoyceZhu 7911d38
Initial plan
Copilot 4f418b1
Add reduced motion and color scheme action inputs
Copilot ac972a3
Fix TypeScript narrowing for new scanner inputs
Copilot 88c9363
Name some types for readability
JoyceZhu 8d104a2
Clarify error messages/documentation
JoyceZhu cf0b579
Add workflow input options for `reducedMotion` and `colorScheme` (#145)
JoyceZhu 90cc14a
chore(deps-dev): Bump minimatch from 10.2.2 to 10.2.4
dependabot[bot] 686a07f
chore(deps-dev): Bump minimatch from 10.2.2 to 10.2.4 (#147)
JoyceZhu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -3,22 +3,22 @@ | |||||
|
|
||||||
| import fs from 'node:fs' | ||||||
| import * as url from 'node:url' | ||||||
| import { spawn } from 'node:child_process' | ||||||
| import {spawn} from 'node:child_process' | ||||||
|
|
||||||
| function spawnPromisified(command, args, { quiet = false, ...options } = {}) { | ||||||
| function spawnPromisified(command, args, {quiet = false, ...options} = {}) { | ||||||
| return new Promise((resolve, reject) => { | ||||||
| const proc = spawn(command, args, options) | ||||||
| proc.stdout.setEncoding('utf8') | ||||||
| proc.stdout.on('data', (data) => { | ||||||
| proc.stdout.on('data', data => { | ||||||
| if (!quiet) { | ||||||
| console.log(data) | ||||||
| } | ||||||
| }) | ||||||
| proc.stderr.setEncoding('utf8') | ||||||
| proc.stderr.on('data', (data) => { | ||||||
| proc.stderr.on('data', data => { | ||||||
| console.error(data) | ||||||
| }) | ||||||
| proc.on('close', (code) => { | ||||||
| proc.on('close', code => { | ||||||
| if (code !== 0) { | ||||||
| reject(code) | ||||||
| } else { | ||||||
|
|
@@ -31,31 +31,32 @@ function spawnPromisified(command, args, { quiet = false, ...options } = {}) { | |||||
| await (async () => { | ||||||
| // If dependencies are not vendored-in, install them at runtime. | ||||||
| try { | ||||||
| await fs.accessSync( | ||||||
| url.fileURLToPath(new URL('./node_modules', import.meta.url)), | ||||||
| fs.constants.R_OK | ||||||
| ) | ||||||
| await fs.accessSync(url.fileURLToPath(new URL('./node_modules', import.meta.url)), fs.constants.R_OK) | ||||||
|
||||||
| await fs.accessSync(url.fileURLToPath(new URL('./node_modules', import.meta.url)), fs.constants.R_OK) | |
| await fs.promises.access(url.fileURLToPath(new URL('./node_modules', import.meta.url)), fs.constants.R_OK) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fs.accessSyncis synchronous, soawait fs.accessSync(...)is misleading. Remove theawait(or switch tofs.promises.access).