Repair core interface readability and keyboard recovery - #208
Merged
Merged
Conversation
MaggieAppleton
added this pull request to stack #219
September 30, 2026 08:27
Preserve the approved original colours while repairing dialog and chat wrapping, loading-state dismissal, keyboard focus recovery, and code-preview keyboard access. Renew the two reviewed design-contract records after integrating main.
MaggieAppleton
force-pushed
the
maggie/design-quality-repairs
branch
from
September 30, 2026 08:40
a9f206b to
d84b663
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long document names could spill out of Delete, chat errors could hide recovery instructions, and Projects could open as a blank panel while loading. Keyboard control could also be lost when a dialog’s selected button disappeared or became disabled.
This change wraps long names and error summaries, preserves room for the chat draft, adds a dismissible Projects loading message, and preserves keyboard control through those transitions. Code previews gain named keyboard-scroll groups and a visible focus indicator.
Original colours retained
Maggie reviewed the colour changes and chose to retain the original appearance: Delete red, quiet timestamps and tool/status text, dimmed queued messages, and the original Pierre code palette and selection. All audit colour changes are reverted. These are explicit design exceptions where they fall below AA contrast; they are not reported as contrast passes. The shared design rules record the decision.
Actual interface
The current screenshot shows the wrapping repair with the original red. Chat and code retain their pre-audit colours.
Verification
d84b663d9807d5ee23a7abd4f346fcad541ad18a: validation (including the full unit suite and PostgreSQL tests), browser integration and container build. Final run. Linux build: 250,702 bytes raw / 79,991 bytes gzip, within the unchanged 80,000-byte compressed limit.Testing uses disposable fake-GitHub data in Chromium at desktop and narrow widths. It is not screen-reader or physical-device certification. A pre-existing failed-dialog Reload button can be covered by the sidebar for mouse input; keyboard reload works and the pointer issue remains a follow-up.
Main now includes #207 and has been incorporated into this branch. Reviewed both changed interface files and renewed their exact design-check records in
a9f206b6; no interface or palette changes were needed. Local validation, types and all 37 design-rule tests pass. Full CI for the combined branch has passed all three required jobs. This PR remains unmerged; #209 follows it.Merge eligibility: the repository permits rebase merges only. Consolidated the exact tested file tree into one commit,
d84b663d, on main. GitHub now confirms it can be rebased. Required checks on this new commit have all passed. GitHub reports both mergeable and rebaseable, with a clean merge state. No product files changed during this history repair.