Add rendered design checks to required browser CI - #209
Merged
Merged
Conversation
MaggieAppleton
changed the base branch from
main
to
maggie/design-quality-repairs
September 30, 2026 08:27
MaggieAppleton
added this pull request to stack #219
September 30, 2026 08:27
MaggieAppleton
force-pushed
the
maggie/design-browser-ci
branch
2 times, most recently
from
September 30, 2026 09:50
5c5cc48 to
0f8d89b
Compare
MaggieAppleton
force-pushed
the
maggie/design-browser-ci
branch
from
September 30, 2026 10:01
0f8d89b to
b92bfc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal: Catch visible changes to Chopin's interface before they reach users, while preserving the appearance choices approved in #208.
What we tested: The required browser CI job opens real examples of Chopin's interface in a fixed Linux Chromium browser. It runs 38 checks across desktop and narrow screens. Those checks compare 32 screenshots with reviewed reference images, exercise menus, dialogs, keyboard focus, scrolling and 200% text, and scan the visible examples for common accessibility problems. The existing system tests cover the running application separately.
What we found: The interface examples match their reviewed images after reconciling this branch with current
main. The original Delete red, quiet conversation metadata and code colours remain as approved. Known colour-contrast findings are recorded precisely; a new or changed finding fails CI. This is targeted coverage of the examples, not a claim that every screen has been tested or is fully accessible.Validation: Locally, all 38 Linux browser checks, 1,711 unit tests, TypeScript checks and the design contract pass. All three required GitHub checks passed on the latest rebased commit.
How the checks run
Approved appearance and tested behavior
Coverage and review instructions