fix(mcp_tool): set skip_summarization on confirmation pause - #6986
Closed
Zsanz3 wants to merge 1 commit into
Closed
Conversation
McpTool's confirmation gate requested confirmation and returned the pause error but never set skip_summarization, so the LLM flow re-invoked the model and retried the tool. Match FunctionTool and set the flag before returning the pause error. Fixes google#6977 Co-authored-by: Zsanz3 <Zsanz3@users.noreply.github.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
thanks for the contribution! we actually just merged the same fix internally: cb0eb22, closing as fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
Problem:
McpTool.run_async'srequire_confirmationgate callstool_context.request_confirmation(...)and returns the pause error dict, but never setstool_context.actions.skip_summarization = True.FunctionTooldoes set that flag. Without it, the LLM flow re-invokes the model and retries the tool, producing an unbounded confirmation loop.Fix:
Set
tool_context.actions.skip_summarization = Trueon the confirmation pause path, matchingFunctionTool.Test:
Assert
skip_summarization is Truein the existing require_confirmation unit test.Testing Instructions