Skip to content

fix(mcp_tool): set skip_summarization on confirmation pause #6986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Zsanz3 wants to merge 1 commit into from
+2 −0
Closed

fix(mcp_tool): set skip_summarization on confirmation pause #6986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/google/adk/tools/mcp_tool/mcp_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,7 @@ async def run_async(
" ToolConfirmation payload."
),
)
tool_context.actions.skip_summarization = True
return {
"error": (
"This tool call requires confirmation, please approve or"
Expand Down
1 change: 1 addition & 0 deletions tests/unittests/tools/mcp_tool/test_mcp_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,6 +1056,7 @@ async def test_run_async_require_confirmation_true_no_confirmation(self):
)
}
tool_context.request_confirmation.assert_called_once()
assert tool_context.actions.skip_summarization is True

@pytest.mark.asyncio
async def test_run_async_require_confirmation_true_rejected(self):
Expand Down