fix(msvc): silence C4244 in AddPowers and complexity pow (#826) - #2286
Open
jameswatsoncraft wants to merge 3 commits into
Open
fix(msvc): silence C4244 in AddPowers and complexity pow (#826)#2286jameswatsoncraft wants to merge 3 commits into
jameswatsoncraft wants to merge 3 commits into
Conversation
Signed-off-by: jameswatsoncraft <jameswatsoncraft@users.noreply.github.com>
Signed-off-by: jameswatsoncraft <jameswatsoncraft@users.noreply.github.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
LebedevRI
reviewed
Aug 12, 2026
|
|
||
| return dst->begin() + static_cast<int>(start_offset); | ||
| return dst->begin() + | ||
| static_cast<typename std::vector<T>::difference_type>(start_offset); |
Collaborator
There was a problem hiding this comment.
Can we just use size_t here? Typename stuff is so ugly.
Signed-off-by: jameswatsoncraft <jameswatsoncraft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes MSVC
/W4warnings called out in #826:AddPowers: usevector<T>::difference_typeinstead ofstatic_cast<int>(size_t)(C4244)FittingCurve: castIterationCounttodoublebeforestd::pow(C4244)CheckHandleralready suppresses C4722 locally incheck.h.Fixes #826.
Test plan
/W4on touched TUs