Skip to content

fix(msvc): silence C4244 in AddPowers and complexity pow (#826) #2286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jameswatsoncraft wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −3
Open

fix(msvc): silence C4244 in AddPowers and complexity pow (#826) #2286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3786d93
fix(msvc): silence C4244 in AddPowers and complexity pow (#826)
jameswatsoncraft Aug 12, 2026
1da0112
fix(msvc): silence C4244 in AddPowers and complexity pow (#826)
jameswatsoncraft Aug 12, 2026
ddba05d
fix: use size_t offset in AddPowers per review
jameswatsoncraft Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/benchmark_register.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ typename std::vector<T>::iterator AddPowers(std::vector<T>* dst, T lo, T hi,
if (i > kmax / mult) break;
}

return dst->begin() + static_cast<int>(start_offset);
return dst->begin() + start_offset;
}

template <typename T>
Expand Down
8 changes: 6 additions & 2 deletions src/complexity.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,13 @@ BigOFunc* FittingCurve(BigO complexity) {
case oN:
return [](IterationCount n) -> double { return static_cast<double>(n); };
case oNSquared:
return [](IterationCount n) -> double { return std::pow(n, 2); };
return [](IterationCount n) -> double {
return std::pow(static_cast<double>(n), 2);
};
case oNCubed:
return [](IterationCount n) -> double { return std::pow(n, 3); };
return [](IterationCount n) -> double {
return std::pow(static_cast<double>(n), 3);
};
case oLogN:
return [](IterationCount n) -> double {
return std::log2(static_cast<double>(n));
Expand Down