feat(list-header): add inner part#30930
Open
brandyscarney wants to merge 2 commits intofeature-8.8from
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
reviewed
Jan 21, 2026
| })} | ||
| > | ||
| <div class="list-header-inner"> | ||
| <div class="list-header-inner" part="inner"> |
Contributor
There was a problem hiding this comment.
Why would this be considered inner instead of content?
Member
Author
There was a problem hiding this comment.
Based on our latest discussion this is correct due to #30931
ShaneK
approved these changes
Feb 27, 2026
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Just a couple nits, which you can ignore if you want. Looks good to me!
| */ | ||
| configs({ directions: ['ltr'], modes: ['md'] }).forEach(({ title, config }) => { | ||
| test.describe(title('list-header: custom'), () => { | ||
| test.describe(title('CSS shadow parts'), () => { |
Member
There was a problem hiding this comment.
Suggested change
| test.describe(title('CSS shadow parts'), () => { | |
| test.describe('CSS shadow parts', () => { |
Nit: The title method just appends mode/direction or mode/direction/palette to the string. In this case, it's redundant to use it in nested describes like this, and usually when we have nested describes we don't use it twice.
| /** | ||
| * @virtualProp {"ios" | "md"} mode - The mode determines which platform styles to use. | ||
| * | ||
| * @part inner - The inner container element that wraps the list header content. |
Member
There was a problem hiding this comment.
Suggested change
| * @part inner - The inner container element that wraps the list header content. | |
| * @part inner - The inner wrapper element that arranges the list header content. |
Nit: Avoid confusing terminology since container is a part
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
The inner structural element of list-header is not exposed as a shadow part, preventing users from being able to customize its styles directly.
What is the new behavior?
innershadow partDoes this introduce a breaking change?