-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(list-header): add inner part #30930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+38
−1
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f653e6b
feat(list-header): add inner part
brandyscarney e53dc7e
test(list-header): add e2e test for css shadow parts
brandyscarney 2393cc8
test(list-header): remove duplicate title in describe
brandyscarney 3f838b2
docs(list-header): update part description
brandyscarney c8df560
Merge branch 'feature-8.8' into FW-6794-list-header
brandyscarney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
core/src/components/list-header/test/custom/list-header.e2e.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import { expect } from '@playwright/test'; | ||
| import { configs, test } from '@utils/test/playwright'; | ||
|
|
||
| /** | ||
| * This behavior does not vary across modes/directions | ||
| */ | ||
| configs({ directions: ['ltr'], modes: ['md'] }).forEach(({ title, config }) => { | ||
| test.describe(title('list-header: custom'), () => { | ||
| test.describe('CSS shadow parts', () => { | ||
| test('should be able to customize inner part', async ({ page }) => { | ||
| await page.setContent( | ||
| ` | ||
| <style> | ||
| ion-list-header::part(inner) { | ||
| background-color: red; | ||
| } | ||
| </style> | ||
|
|
||
| <ion-list-header>Header</ion-list-header> | ||
| `, | ||
| config | ||
| ); | ||
|
|
||
| const header = page.locator('ion-list-header'); | ||
| const backgroundColor = await header.evaluate((el) => { | ||
| const shadowRoot = el.shadowRoot; | ||
| const inner = shadowRoot?.querySelector('.list-header-inner'); | ||
| return inner ? window.getComputedStyle(inner).backgroundColor : ''; | ||
| }); | ||
| expect(backgroundColor).toBe('rgb(255, 0, 0)'); | ||
| }); | ||
| }); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would this be considered
innerinstead ofcontent?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on our latest discussion this is correct due to #30931