Repository navigation
ci: build and release both extensions with release-please - #4
Merged
Merged
Conversation
kermitsxb
changed the title
kermitsxb
marked this pull request as ready for review
October 1, 2026 12:39
kermitsxb
added a commit
that referenced
this pull request
Oct 1, 2026
* fix(extension): map Firefox native port errors * feat(build): derive the Firefox manifest * feat(build): build and sign the Firefox extension * feat(install): register the native host for Firefox * docs: Firefox install and signing * fix(extension): map the Firefox refused-host error * chore: build before Firefox lint and sign; doc fixes * ci: build and release both extensions with release-please (#4) * ci: build both extensions and release them on version tags * docs: releases * ci: cut releases with release-please * docs: release-please releases * ci: make Firefox signing safe to retry (#5) * ci: reuse already-submitted AMO versions when signing * docs: Firefox signing retries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3 (Firefox extension).
Summary
.github/workflows/release.yml:build(runs on PRs and pushes tomain):npm ci, test, typecheck andlint:firefox(which builds first). It uploads the Chrome zip and the unsignedextension-firefox/as a run artifact.release-please(runs on pushes tomain): usesgoogleapis/release-please-action@v5to keep a release PR up to date. The PR bumps the version inpackage.jsonand inextension/manifest.json(throughextra-files) and updatesCHANGELOG.md, all from Conventional Commits. Merging the PR tagsvX.Y.Zand creates the GitHub Release.assets(runs only whenrelease_created):scripts/release-version.mjschecks that the tag matches the manifest version;npm run sign:firefoxsigns the Firefox extension on AMO (unlisted, using theWEB_EXT_API_KEY/WEB_EXT_API_SECRETsecrets);gh release uploadattachesgithub-orca-chrome-X.Y.Z.zipandgithub-orca-firefox-X.Y.Z.xpito the release.Everything runs in a single workflow because tags created with
GITHUB_TOKENdo not trigger other workflows. Config lives inrelease-please-config.json(release-type: node, tags likev0.2.0) and in.release-please-manifest.json(0.1.0).package.jsonwas aligned from1.0.0to0.1.0.Repo setting changed: Allow GitHub Actions to create and approve pull requests is now enabled, so that release-please can open its PR with
GITHUB_TOKEN. Because that PR is created byGITHUB_TOKEN, it does not trigger thebuildjob; it only changes versions and the changelog.The native host is not released. README "Releases" and AGENTS.md are updated.
Verification
actionlintpasses.npm testpasses (233 tests) andnpm run typecheckis clean.releaseVersiontests cover a matching tag, a mismatched tag and a tag without thevprefix.Not verified
0.2.0, with the whole history in the changelog because no tag exists yet.