Repository navigation
fix(aiclient): propagate messages streaming provider errors - #3281
Open
alexcastgonz (pcbeingused333) wants to merge 2 commits into
Open
alexcastgonz (pcbeingused333) wants to merge 2 commits into
alexcastgonz (pcbeingused333) wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messages streaming can return a partial answer as a successful completion when the provider sends an SSE
errorevent, such asoverloaded_error, after a text delta.The Messages stream event union omitted error events, so the decoder silently returned an empty piece. Add the error event type and return its message as
StreamPiece.error. The existing stream consumer throws that error, preventing the partial output from being treated as a completed response.Testing and validation
Add parameterized regression coverage for provider errors both before any text and after a partial text delta. The tests assert that the decoder returns an Error with the provider message and no text or usage on the error piece.
Both new cases fail on
main(expected undefined to be an instance of Error) and pass with this change; the rest of theMessagesWireApiProvidersuite still passes. No paid API calls are required.This change was prepared with AI assistance (Codex).