Skip to content

fix(aiclient): propagate messages streaming provider errors #3281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexcastgonz (pcbeingused333) wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(aiclient): propagate messages streaming provider errors #3281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0de9bd6
fix(aiclient): propagate messages streaming provider errors
pcbeingused333 Nov 11, 2026
8b5cb61
style(aiclient): format streaming error regression test
pcbeingused333 Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ts/packages/aiclient/src/wireApiProvider/messages.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,16 @@ export interface RawContentBlockStopEvent {
type: "content_block_stop";
}

export interface RawMessageErrorEvent {
type: "error";
error: {
type: string;
message: string;
};
}

export type RawMessageStreamEvent =
| RawMessageErrorEvent
| RawMessageStartEvent
| RawMessageDeltaEvent
| RawMessageStopEvent
Expand Down
5 changes: 5 additions & 0 deletions ts/packages/aiclient/src/wireApiProvider/messagesWireApiProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,11 @@ export class MessagesWireApiProvider implements ProviderAdapter {
const evt = JSON.parse(raw) as RawMessageStreamEvent;
const piece: StreamPiece = {};

if (evt.type === "error") {
piece.error = new Error(evt.error.message);
return piece;
}

if (
evt.type === "content_block_delta" &&
evt.delta.type === "text_delta"
Expand Down
33 changes: 33 additions & 0 deletions ts/packages/aiclient/test/providerAdapter.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,39 @@ describe("ChatCompletionsWireApiProvider (default path is byte-identical)", () =
describe("MessagesWireApiProvider", () => {
const adapter = adapterFor("messages");

test.each([false, true])(
"stream reports provider errors (partial text: %s)",
(partialText) => {
const decoder = adapter.createStreamDecoder!(
makeRequest({ stream: true }),
);
if (partialText) {
expect(
decoder.push(
JSON.stringify({
type: "content_block_delta",
index: 0,
delta: {
type: "text_delta",
text: "Partial answer",
},
}),
).text,
).toBe("Partial answer");
}
const piece = decoder.push(
JSON.stringify({
type: "error",
error: { type: "overloaded_error", message: "Overloaded" },
}),
);
expect(piece.error).toBeInstanceOf(Error);
expect(piece.error?.message).toBe("Overloaded");
expect(piece.text).toBeUndefined();
expect(piece.usage).toBeUndefined();
},
);

test("buildRequestBody splits system prompt, requires max_tokens", () => {
const req = makeRequest({
modelName: "claude-3-5-sonnet",
Expand Down