Skip to content

fix: search task root sub dir content fetch #16142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alperozturk96 merged 7 commits into from
Dec 19, 2025
Merged

fix: search task root sub dir content fetch #16142

alperozturk96 merged 7 commits into from
Dec 19, 2025
+44 −25

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Dec 15, 2025 •
edited
Loading

  • Tests written, or not not needed

Issue: #16140

@alperozturk96 alperozturk96 linked an issue Dec 15, 2025 that may be closed by this pull request
Opening Sub Directory from Favorites Root Shows Wrong Folder Content #16140
Closed
4 tasks
@alperozturk96
Copy link
Collaborator Author

alperozturk96 commented Dec 15, 2025

/backport to stable-3.35

tobiasKaminsky

This comment was marked as resolved.

Sign in to view

@alperozturk96 alperozturk96 force-pushed the fix/oc-file-list-search-sub-dir-visibility-from-root branch 3 times, most recently from abdce03 to b33844c Compare December 18, 2025 08:27
@nextcloud nextcloud deleted a comment from github-actions bot Dec 18, 2025
@alperozturk96 alperozturk96 force-pushed the fix/oc-file-list-search-sub-dir-visibility-from-root branch 4 times, most recently from a26d14c to 27fbc24 Compare December 19, 2025 08:12
@alperozturk96
fix: search task root sub dir content fetch
cb088eb 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix: search task root sub dir content fetch
74c9dc1 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
use saveFileWithParent
78638d7 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
use saveFileWithParent
cb919ef 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
revert
3159e7c 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix etag saving logic
eb71854 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix etag saving logic
ade6bcc 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the fix/oc-file-list-search-sub-dir-visibility-from-root branch from 558964d to ade6bcc Compare December 19, 2025 11:08
@github-actions
Copy link

github-actions bot commented Dec 19, 2025

Codacy

SpotBugs

CategoryBaseNew
Bad practice4343
Correctness7374
Dodgy code257257
Experimental11
Internationalization77
Malicious code vulnerability33
Multithreaded correctness3434
Performance4344
Security1818
Total479481

SpotBugs increased!

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16142.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96
Copy link
Collaborator Author

alperozturk96 commented Dec 19, 2025

Object not found for spotbugs increased message

Screenshot 2025-12-19 at 12 45 57

@alperozturk96 alperozturk96 merged commit 0758e25 into master Dec 19, 2025
16 of 21 checks passed
@alperozturk96 alperozturk96 deleted the fix/oc-file-list-search-sub-dir-visibility-from-root branch December 19, 2025 11:46
@backportbot backportbot bot mentioned this pull request Dec 19, 2025
Merged
@alperozturk96 alperozturk96 added this to the Nextcloud App 3.35.0 milestone Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 3.35.0

Development

Successfully merging this pull request may close these issues.

Opening Sub Directory from Favorites Root Shows Wrong Folder Content

3 participants

@alperozturk96 @tobiasKaminsky