Skip to content

test(h2): isolate connection churn seeds - #5643

Open
mcollina wants to merge 2 commits into
mainfrom
test/reduce-h2-churn-flakiness
Open

test(h2): isolate connection churn seeds#5643
mcollina wants to merge 2 commits into
mainfrom
test/reduce-h2-churn-flakiness

Conversation

@mcollina

@mcollina mcollina commented Aug 3, 2026

Copy link
Copy Markdown
Member

Scope the HTTP/2 churn test cleanup to each seed so its TLS server, sessions, agent, and keepalive timer are released before the next seed starts.

Native Linux x64 investigation showed that the remaining Node.js 24 failures are process-level memory-corruption crashes, not assertions from this test. Although the cores usually fail later in V8's concurrent Maglev compiler, the source is Node's HTTP/2 binding calling nghttp2 send/close paths reentrantly while nghttp2_session_mem_recv() is active.

Skip this stress test on Node.js 24 until the HTTP/2 fix in nodejs/node#65093 reaches a release. Other Node.js versions continue to run both seeded churn cases.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
mcollina requested review from metcoder95 and trivikr August 3, 2026 13:51
@codecov-commenter

codecov-commenter commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.44%. Comparing base (3926499) to head (fa9e682).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5643      +/-   ##
==========================================
+ Coverage   93.40%   93.44%   +0.04%     
==========================================
  Files         110      110              
  Lines       38695    38776      +81     
==========================================
+ Hits        36144    36236      +92     
+ Misses       2551     2540      -11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@metcoder95 metcoder95 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests doesn’t seem happy

@mcollina

mcollina commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

It’s worse than that, there is a bug in Node 24 that’s causing a sigsev.

Node.js 24 has an HTTP/2 memory corruption bug that can crash this stress test before its assertions run.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants