Skip to content

test(h2): isolate connection churn seeds #5643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcollina wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −6
Open

test(h2): isolate connection churn seeds #5643

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9448c96
test(h2): isolate connection churn seeds
mcollina Aug 3, 2026
fa9e682
test(h2): skip churn test on Node.js 24
mcollina Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions test/http2-request-never-settles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict'

Check failure on line 1 in test/http2-request-never-settles.js

View workflow job for this annotation

GitHub Actions / Test with Node.js 25 on ubuntu-latest with WASM SIMD disabled / Test with Node.js 25 on ubuntu-latest

/home/runner/work/undici/undici/test/http2-request-never-settles.js 

'test failed'

const assert = require('node:assert')
const { test, after } = require('node:test')
const { test } = require('node:test')
const { constants, createSecureServer } = require('node:http2')
const { once } = require('node:events')
const { Readable } = require('node:stream')
Expand All @@ -10,6 +10,8 @@

const { Agent } = require('..')

const skipOnNode24 = Number(process.versions.node.split('.')[0]) === 24

// completeRequestStream() runs on an h2 stream's 'close':
//
// releaseRequestStream(this)
Expand Down Expand Up @@ -115,7 +117,9 @@
}

for (const seed of SEEDS) {
test(`every h2 request settles under connection churn (seed ${seed})`, async () => {
test(`every h2 request settles under connection churn (seed ${seed})`, {
skip: skipOnNode24 && 'Node.js 24 has an HTTP/2 memory corruption bug'
}, async (t) => {
const timer = setInterval(() => {}, 1000)
const rnd = makeRandom(seed)
const server = await churningServer(rnd)
Expand All @@ -127,10 +131,16 @@
headersTimeout: 500,
bodyTimeout: 500
})
after(async () => {
await agent.destroy()
server.shutdown()
clearInterval(timer)
// Release each seed's resources before the next test starts. A file-level
// after hook kept every TLS server and keepalive timer until all seeds had
// finished, making this churn test sensitive to CI load.
t.after(async () => {
try {
await agent.destroy()
} finally {
server.shutdown()
clearInterval(timer)
}
})

const unsettled = []
Expand Down
Loading