Repository navigation
Preserve floor-plan backgrounds during upload and rollback failures - #700
Merged
Merged
Conversation
Hold original and uploaded background identities in a private directory, publish without replacing a competing destination, and restore only verified entries without overwriting intervening files. Preserve original, uploaded and competing data when publication or metadata rollback cannot safely finish. Create uploads relative to the held private directory. Add 24 direct-handler regressions with private SQLite/filesystem fixtures and existing CMake/integration/sanitizer registration. On origin/main 8927bc8 the suite fails 17/24; the isolated fix passes 24/24 under Debug ASan/UBSan. No application service or shared legacy fixture was used. Uncertain recovery artifacts are retained rather than recursively removed.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #701; merge the shared CI cleanup first. This branch includes that exact shared commit so its workflow changes disappear from this PR after #701 merges. Suite membership is declared beside the tests in CMake; this fix has no independent workflow edits. All three remaining fix branches merge cleanly with each other.
Replacing a floor-plan background could discard an unknown backup or overwrite a competing file during publication or database-error rollback.
Hold the original and uploaded files in a private directory, publish without replacing an intervening destination, and restore only the inspected original. If recovery cannot safely finish, preserve the files for inspection.
main: 17 of 24 cases fail before the fix; all 24 pass with ASan/UBSan. Direct-handler tests use private SQLite/filesystem fixtures and cover normal upload, publication failures, substituted entries and rollback conflicts.ctest --test-dir build/focused-debug --output-on-failure -R '^test_floor_plan_background_publication$'.Publication requires atomic no-replace filesystem support and fails conservatively if unavailable. Uncertain recovery artifacts are retained. Filesystem and SQLite updates are not atomic together; already-open writers, other-MIME cleanup and GET/DELETE behavior remain outside this change.
Extracted independently from #693; no foundation framework or policy exceptions. Hosted CI is required before merge.
Revalidated after updating from main and adopting the shared CI suites: focused ASan/UBSan regressions pass, and CTest labels select the existing suite plus only this PR’s regressions.