Repository navigation
Declare CI test suites beside CMake registrations - #701
Merged
Merged
Conversation
This was referenced Oct 31, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each native regression currently edits both an explicit build list and a long CTest expression in shared workflows. Independent fixes repeatedly conflict on those same lines. Component browser regressions also add a named workflow step per suite.
Declare native suite membership beside the CMake test registration with
CI_UNITandCI_SANITIZER. Those declarations supply both aggregate build dependencies and CTest labels. Workflows now buildci-unit-testsand select labels; sanitizer smoke/build behavior stays intact. A single browser step discovers*.browser.spec.jssuites.Validation:
git diff --checkpass. The entire 65/43-test runtime selection was not rerun locally; hosted CI runs it.Merge this CI-only change before #698, #699 and #700. Those fixes declare their own suites in CMake and no longer modify either workflow. Their CMake registrations occupy separate locations so merging one does not conflict with another.