Photos: part 2#229
Merged
Merged
Conversation
Merged
danielbui12
reviewed
Jun 25, 2026
franciscoaguirre
force-pushed
the
dapp-example
branch
from
cc88d3c to
89285b1
Compare
franciscoaguirre
force-pushed
the
photos-2
branch
from
61fadac to
b8bc0c1
Compare
franciscoaguirre
added a commit
that referenced
this pull request
Jun 25, 2026
Address PR #229 review feedback (danielbui12): - Extract the duplicated M2/M3 "re-enumerate -> recompute root -> read on-chain anchor (retry for best-block lag) -> assert recomputed == on-chain == index_root" block into a local verifyAnchor helper, parameterized by an isStale predicate. - Replace the hardcoded retry bound 5 with a named ANCHOR_RETRY_BLOCKS constant. Behavior-preserving: identical asserts and console output.
bkontur
reviewed
Jun 26, 2026
bkontur
approved these changes
Jun 26, 2026
Address PR #229 review feedback (danielbui12): - Extract the duplicated M2/M3 "re-enumerate -> recompute root -> read on-chain anchor (retry for best-block lag) -> assert recomputed == on-chain == index_root" block into a local verifyAnchor helper, parameterized by an isStale predicate. - Replace the hardcoded retry bound 5 with a named ANCHOR_RETRY_BLOCKS constant. Behavior-preserving: identical asserts and console output.
franciscoaguirre
force-pushed
the
photos-2
branch
from
4f6fbfa to
2eb1c18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #133