Repository navigation
refactor: Bump js-yaml from 3.14.2 to 3.15.2 and 4.1.1 to 4.3.2 - #950
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
🎉 This change has been released in version 3.1.0 |
Closes #940
Updates both
js-yamlcopies in the lock file to the newest release of their major version line:js-yaml3.14.2 → 3.15.2, used by@istanbuljs/load-nyc-config(vianyc)js-yaml4.1.1 → 4.3.2, used bycosmiconfig(viasemantic-release)This resolves the open js-yaml security alerts in both version lines (GHSA-2883-xcg3-v3hh, GHSA-5p4m-2wfm-xmqj, GHSA-52cp-r559-cp3m, GHSA-h67p-54hq-rp68). Both copies are development-only dependencies (
npm ls js-yaml --omit=devis empty), so no release is needed.The lock file was regenerated with
npm update js-yamlon the currentmaster. Only the twojs-yamlentries change. The lock file in #940 is stale; it also moved the 4.x copy to 4.3.2, but additionally pruned the optional peer entriesgaxios,gcp-metadataandnode-fetch(underparse-server),smart-bufferandsocks. This lock file keeps them, as onmaster.Changes
js-yaml 3.14.2 → 3.15.2
maxTotalMergeKeysloader option (default 10000), which limits the total number of keys processed by YAML merge (<<) in one load call. The release notes mentionsafeLoad()/safeLoadAll(), but the default is set in the shared loader state, so it also applies toload()/loadAll(). Exceeding it throwsmerge keys exceeded maxTotalMergeKeys (10000).!!omapduplicate key detection.<<: [...]) are hard-limited to 100 entries; more throwsabnormal merge sequence size. Security:mergeMappings()now charges one unit towardmaxTotalMergeKeysfor each merged source mapping, empty or not, before counting its keys (fix: count empty merge sources against maxTotalMergeKeys nodeca/js-yaml#797, nodeca/js-yaml@3485bc0). This applies to merge sequences and to single<<: *anchormerges, so documents with many merges reach the 10000 limit slightly sooner.js-yaml 4.1.1 → 4.3.2
maxDepthloader option (default 100). Nesting 100 levels deep throwsnesting exceeded maxDepth (100).maxMergeSeqLengthloader option (default 20). It was replaced bymaxTotalMergeKeysin 4.3.0.1_000now loads as the string"1_000"instead of1000.!!str 16: 32, which previously failed to load, now load.|/>scalar without an indentation indicator, whose first content line is not indented, throwsmissing indentation for block scalar.1e400) now loads as a string instead ofInfinity;.infand.nanare unchanged.%TAG !e1! ...).maxTotalMergeKeys.docs/safety.md, added sourcemaps todist/builds, switched dev toolchains to Vite / neostandard, updated the demo, reorganized tests, fixed test coverage for Extra new line added nodeca/js-yaml#221, and stopped keepingdist/in the repository.maxTotalMergeKeysloader option (default 10000), replacingmaxMergeSeqLength. Exceeding it throwsmerge keys exceeded maxTotalMergeKeys (10000). Restored ES5 UMD builds.!!omapduplicate key detection.<<: [...]) are hard-limited to 100 entries; more throwsabnormal merge sequence size. Security:mergeMappings()now charges one unit towardmaxTotalMergeKeysfor each merged source mapping, empty or not, before counting its keys (fix: count empty merge sources against maxTotalMergeKeys nodeca/js-yaml#797, nodeca/js-yaml@d90b661). This applies to merge sequences and to single<<: *anchormerges, so documents with many merges reach the 10000 limit slightly sooner.The 4.2.0 changes alter how some YAML documents parse, but they don't reach this repository. Both parents call
load()only when they read a YAML config file, and this repository has none:cosmiconfig(semantic-release config) parses YAML only for.releaserc,.releaserc.yaml/.yml,.config/releaserc*,package.yamland.config/config.yaml/.yml. This repository usesrelease.config.js, and.releasercis a template directory.@istanbuljs/load-nyc-configparses YAML only for.nycrc.yml/.yaml. This repository's.nycrcis JSON.Breaking Changes
None
Code Changes Required
None — the upgrade is a drop-in replacement.
Summary by CodeRabbit