Fix mem leak when duphandle fails in curl_clone_obj - #22894
Closed
Sjord wants to merge 1 commit into
Closed
Conversation
LamentXU123
approved these changes
Jul 27, 2026
Member
|
Please rebase to master to pass the arm CI :) |
Move init_curl_handle so that we don't leak memory if curl_easy_duphandle fails within curl_clone_obj. init_curl_handle allocates things, and curl_free_obj frees that again. But curl_free_obj does nothing if ch->cp is not set. In curl_clone_obj, do the allocation only once we have a valid cp, so that curl_free_obj actually deallocates the memory again. If curl_easy_duphandle fails we have not allocated anything and nothing is cleaned up.
Sjord
force-pushed
the
curl-clone-fail-leak
branch
from
July 27, 2026 09:27
d20129b to
dd965a0
Compare
Member
|
This feels like more like a bug fix to me. @Sjord do you think this should be merged into stable versions? (i.e. 8.4 8.5) |
Contributor
Author
|
Yes: #22899 |
Sjord
marked this pull request as draft
July 27, 2026 09:58
Contributor
Author
|
This PR should probably not be merged, but #22899 instead. |
Member
|
superseded by #22899 |
Member
|
Merged in 3163ac7. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move init_curl_handle so that we don't leak memory if curl_easy_duphandle fails within curl_clone_obj.
init_curl_handle allocates things, and curl_free_obj frees that again. But curl_free_obj does nothing if ch->cp is not set. In curl_clone_obj, do the allocation only once we have a valid cp, so that curl_free_obj actually deallocates the memory again. If curl_easy_duphandle fails we have not allocated anything and nothing is cleaned up.