ext/curl: Fix mem leak when duphandle fails in curl_clone_obj - #22899
Closed
Sjord wants to merge 1 commit into
Closed
ext/curl: Fix mem leak when duphandle fails in curl_clone_obj#22899Sjord wants to merge 1 commit into
Sjord wants to merge 1 commit into
Conversation
Member
|
nit: please prefix commit title with |
LamentXU123
changed the title
Member
|
This is still targeting master @Sjord |
Move init_curl_handle so that we don't leak memory if curl_easy_duphandle fails within curl_clone_obj. init_curl_handle allocates things, and curl_free_obj frees that again. But curl_free_obj does nothing if ch->cp is not set. In curl_clone_obj, do the allocation only once we have a valid cp, so that curl_free_obj actually deallocates the memory again. If curl_easy_duphandle fails we have not allocated anything and nothing is cleaned up.
Sjord
force-pushed
the
curl-clone-fail-leak-8.4
branch
from
July 27, 2026 11:13
899f57d to
07f468f
Compare
Contributor
Author
|
Thanks, I put |
TimWolla
approved these changes
Jul 27, 2026
LamentXU123
approved these changes
Jul 27, 2026
LamentXU123
left a comment
LamentXU123
left a comment
Member
There was a problem hiding this comment.
Thank you. I will take care of merging. Now let's close #22894 as superseded.
LamentXU123
added a commit
that referenced
this pull request
Jul 27, 2026
* PHP-8.5: ext/curl: fix mem leak when duphandle fails in curl_clone_obj (#22899)
pull Bot
pushed a commit
to Mattlk13/php-src
that referenced
this pull request
Jul 27, 2026
* PHP-8.4: ext/curl: fix mem leak when duphandle fails in curl_clone_obj (php#22899)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move init_curl_handle so that we don't leak memory if curl_easy_duphandle fails within curl_clone_obj.
init_curl_handle allocates things, and curl_free_obj frees that again. But curl_free_obj does nothing if ch->cp is not set. In curl_clone_obj, do the allocation only once we have a valid cp, so that curl_free_obj actually deallocates the memory again. If curl_easy_duphandle fails we have not allocated anything and nothing is cleaned up.
Same as #22894, but for PHP 8.4.