fix(core): use onMouseEnter/Leave in WebView to prevent duplicate events#32
Open
Sigmabrogz wants to merge 1 commit intoprozilla-os:mainfrom
Open
fix(core): use onMouseEnter/Leave in WebView to prevent duplicate events#32Sigmabrogz wants to merge 1 commit intoprozilla-os:mainfrom
Sigmabrogz wants to merge 1 commit intoprozilla-os:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the issue where difficulty dropdown in Minesweeper (and other WebView apps) closes immediately.
Problem
Closes #28
The
WebViewcomponent was usingonMouseOverandonMouseOutwhich bubble up from children and trigger continuously as the mouse moves over internal elements like the iframe or native dropdowns. This caused rapid firing ofwindow.focus()inonMouseOut, immediately blurring the dropdown inside the iframe and causing it to close.Solution
Replaced
onMouseOverandonMouseOutwithonMouseEnterandonMouseLeavewhich only trigger when the mouse actually enters or leaves the parent container, avoiding bubbling from children elements.Testing
(Note:
mainbranch currently has unrelated TS compilation errors for@prozilla-os/sharedwhich appear to be pre-existing, but my changes only modify theWebViewcomponent safely).Checklist
WebView.tsx