Skip to content

fix(core): use onMouseEnter/Leave in WebView to prevent duplicate events #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sigmabrogz wants to merge 2 commits into from
Closed

fix(core): use onMouseEnter/Leave in WebView to prevent duplicate events #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe388e5
fix(core): use onMouseEnter and onMouseLeave in WebView to prevent du…
Sigmabrogz Mar 12, 2026
96ebc1f
fix(core): verify mouse bounds on mouse leave to support Firefox ifra…
Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions packages/core/src/components/_utils/web-view/WebView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,23 @@ export const WebView: FC<WebViewProps> = forwardRef<HTMLIFrameElement>(({ source
};
}, [focus, hovered]);

const onMouseOver = () => {
const onMouseEnter = () => {
setHovered(true);
};

const onMouseOut = () => {
const onMouseLeave = (e: React.MouseEvent<HTMLDivElement>) => {
// In Firefox, entering an iframe triggers a mouseleave event because it's a different document.
// We verify if the mouse is still within the bounds of the WebView to prevent losing hover state.
const rect = e.currentTarget.getBoundingClientRect();
if (
e.clientX > rect.left &&
e.clientX < rect.right &&
e.clientY > rect.top &&
e.clientY < rect.bottom
) {
return;
}

window.focus();
setHovered(false);
};
Expand All @@ -47,7 +59,7 @@ export const WebView: FC<WebViewProps> = forwardRef<HTMLIFrameElement>(({ source
delete iframeProps.setIconUrl;
delete iframeProps.standalone;

return <div className={styles.WebView} onMouseOver={onMouseOver} onMouseOut={onMouseOut}>
return <div className={styles.WebView} onMouseEnter={onMouseEnter} onMouseLeave={onMouseLeave}>
<iframe
ref={ref}
src={source}
Expand All @@ -56,4 +68,4 @@ export const WebView: FC<WebViewProps> = forwardRef<HTMLIFrameElement>(({ source
{...iframeProps}
/>
</div>;
}) as FC;
}) as FC;