fix(backstage): correctly render lightspeed image fields regardless if they are string or map [RHDHBUGS-3091]#385
Conversation
… unset Using common.tplvalues.render on a map may dump it as multi-line YAML inline, producing invalid output. ref: RHDHBUGS-3091 Assisted-by: Claude
|
string or map [RHDHBUGS-3091]
Member
Author
|
/cc @Jdubrick |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description of the change
In the rhdh-chart repo, the lightspeed image fields are simple strings in the values file:
rhdh-chart/charts/backstage/values.yaml
Lines 150 to 153 in 3275bcf
But in the downstream chart, they are maps (note that the tag/digest is missing as well):
Which issue(s) does this PR fix or relate to
Fixes https://redhat.atlassian.net/browse/RHDHBUGS-3091
How to test changes / Special notes to the reviewer
Render the backstage chart against the values file mentioned in https://redhat.atlassian.net/browse/RHDHBUGS-3091
Checklist
Chart.yamlaccording to Semantic Versioning.values.yamland added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Runpre-commit run --all-filesto run the hooks and then push any resulting changes. The pre-commit Workflow will enforce this and warn you if needed.pre-commithook.ct lintcommand.