Skip to content

fix(backstage): correctly render lightspeed image fields regardless if they are string or map [RHDHBUGS-3091]#385

Open
rm3l wants to merge 2 commits intoredhat-developer:mainfrom
rm3l:RHDHBUGS-3091--helm-chart-1-10-116-ci-and-1-10-117-ci-could-not-be-applied-backstage-deployment-yaml-error-converting-yaml-to-json-yaml-line-141
Open

fix(backstage): correctly render lightspeed image fields regardless if they are string or map [RHDHBUGS-3091]#385
rm3l wants to merge 2 commits intoredhat-developer:mainfrom
rm3l:RHDHBUGS-3091--helm-chart-1-10-116-ci-and-1-10-117-ci-could-not-be-applied-backstage-deployment-yaml-error-converting-yaml-to-json-yaml-line-141

Conversation

@rm3l
Copy link
Copy Markdown
Member

@rm3l rm3l commented May 6, 2026

Description of the change

In the rhdh-chart repo, the lightspeed image fields are simple strings in the values file:

initContainer:
name: lightspeed-rag-init
# -- Full image reference for the Lightspeed RAG bootstrap init container. Override for disconnected environments.
image: quay.io/redhat-ai-dev/rag-content:release-1.9-lls-0.5.0-642c567fe10a62b5ff711654306b72912f341e05

But in the downstream chart, they are maps (note that the tag/digest is missing as well):

    initContainer:
      name: lightspeed-rag-init
      # -- Full image reference for the Lightspeed RAG bootstrap init container. Override for disconnected environments.
      image:
        registry: quay.io
        repository: rhdh/rhdh-rag-content-rhel9@sha256
        # tag is set to digest via prepare.sh script
        # tag: "${RAG_CONTENT_DIGEST}"

        tag: ""

Which issue(s) does this PR fix or relate to

Fixes https://redhat.atlassian.net/browse/RHDHBUGS-3091

How to test changes / Special notes to the reviewer

Render the backstage chart against the values file mentioned in https://redhat.atlassian.net/browse/RHDHBUGS-3091

Checklist

  • For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
  • For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Run pre-commit run --all-files to run the hooks and then push any resulting changes. The pre-commit Workflow will enforce this and warn you if needed.
  • JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
  • Tests pass using the Chart Testing tool and the ct lint command.
  • If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

rm3l added 2 commits May 6, 2026 15:19
… unset

Using common.tplvalues.render on a map may dump it
as multi-line YAML inline, producing invalid output.

ref: RHDHBUGS-3091

Assisted-by: Claude
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

@rm3l rm3l changed the title fix(backstage): correctly render lightspeed image fields even if some fields are unset [RHDHBUGS-3091] fix(backstage): correctly render lightspeed image fields regardless if they are string or map [RHDHBUGS-3091] May 6, 2026
@rm3l
Copy link
Copy Markdown
Member Author

rm3l commented May 6, 2026

/cc @Jdubrick

@openshift-ci openshift-ci Bot requested a review from Jdubrick May 6, 2026 13:39
Copy link
Copy Markdown

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants