Add local repository support to redis-benchmarks-spec-cli to create ZIP archives locally instead of fetching from GitHub, fixing 404 errors when using --redis_repo with local commits #340
+148
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…00Kkeys-hash-hgetex-5-fields-10B-values.yml Co-authored-by: Paulo Sousa <[email protected]>
…00Kkeys-hash-hexpire-5-fields-10B-values.yml Co-authored-by: Paulo Sousa <[email protected]>
- Modified get_archive_zip_from_hash to create ZIP archives locally when local_repo_path is provided
- Added git archive with proper prefix to match GitHub directory structure (redis-{commit_hash}/)
- Updated get_commit_dict_from_sha to extract timestamps from local repositories
- Modified CLI to pass local repository path through the call chain
- Fixes 404 errors when using --redis_repo with local commits that don't exist on GitHub
- Maintains backward compatibility with GitHub repository fetching
paulorsousa
previously approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.