Skip to content

chore: delete kv channel#4583

Merged
MasterPtato merged 1 commit intomainfrom
04-06-chore_delete_kv_channel
Apr 8, 2026
Merged

chore: delete kv channel#4583
MasterPtato merged 1 commit intomainfrom
04-06-chore_delete_kv_channel

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@claude
Copy link
Copy Markdown

claude bot commented Apr 7, 2026

Review: chore: delete kv channel

This PR cleanly removes the entire KV channel subsystem (+4 / -2,775 lines). The deletion is thorough and systematic across all layers.

What's removed:

  • Engine-side WebSocket handler (pegboard-kv-channel)
  • BARE protocol schema (engine/sdks/schemas/kv-channel-protocol/v1.bare)
  • Rust protocol crate (engine/sdks/rust/kv-channel-protocol)
  • TypeScript protocol SDK (engine/sdks/typescript/kv-channel-protocol)
  • Guard routing for /kv/connect
  • TypeScript KV channel manager (runtime-router/kv-channel.ts)
  • /kv/connect route from the runtime router

Looks good:

  • Workspace configs (Cargo.toml, pnpm-workspace.yaml) are cleaned up consistently
  • CLAUDE.md sync requirements for the KV channel protocol are removed
  • The @rivetkit/engine-kv-channel-protocol dependency is dropped from rivetkit's package.json
  • The actor gateway correctly removes the /kv/connect skip — requests to that path will now fall through to normal 404 handling since the engine no longer serves it either

Minor nit — stale section header in CLAUDE.md:
The section is still titled "Native SQLite & KV Channel" but all KV channel-specific content was removed. The remaining bullets only describe VFS sync requirements. Consider renaming to just "Native SQLite" to avoid confusion.

Worth verifying:
The CLAUDE.md notes that rivetkit-typescript/packages/sqlite-native/src/vfs.rs and kv.rs implement a VFS backed by KV operations. Since those files aren't touched in this PR, it's worth confirming that sqlite-native was either: (a) already migrated to a different transport before this PR, (b) removed separately, or (c) the VFS KV operations now go through the runner protocol directly rather than the dedicated channel. If (c), the two-entry CLAUDE.md rule about keeping VFS implementations in sync still applies but no longer needs a channel-specific sync note — which is consistent with what was removed.

Overall a clean, well-scoped deletion. No functional concerns identified.

Copy link
Copy Markdown
Contributor

MasterPtato commented Apr 8, 2026

Merge activity

  • Apr 8, 8:52 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 8, 9:18 PM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 8, 9:18 PM UTC: @MasterPtato merged this pull request with Graphite.

@MasterPtato MasterPtato changed the base branch from 04-06-feat_engine_rust_runner to graphite-base/4583 April 8, 2026 21:14
@MasterPtato MasterPtato changed the base branch from graphite-base/4583 to main April 8, 2026 21:16
@MasterPtato MasterPtato force-pushed the 04-06-chore_delete_kv_channel branch from 8cfaa64 to 1e05bfc Compare April 8, 2026 21:17
@MasterPtato MasterPtato merged commit fd731ca into main Apr 8, 2026
5 of 13 checks passed
@MasterPtato MasterPtato deleted the 04-06-chore_delete_kv_channel branch April 8, 2026 21:18
@MasterPtato MasterPtato mentioned this pull request Apr 9, 2026
11 tasks
@NathanFlurry NathanFlurry mentioned this pull request Apr 9, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants