Skip to content

chore: revert actor v2 hack#4586

Merged
MasterPtato merged 1 commit intomainfrom
04-07-chore_revert_actor_v2_hack
Apr 8, 2026
Merged

chore: revert actor v2 hack#4586
MasterPtato merged 1 commit intomainfrom
04-07-chore_revert_actor_v2_hack

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link
Copy Markdown

railway-app bot commented Apr 8, 2026

🚅 Deployed to the rivet-pr-4586 environment in rivet-frontend

Service Status Web Updated (UTC)
kitchen-sink ❌ Build Failed (View Logs) Web Apr 8, 2026 at 9:27 pm
website 😴 Sleeping (View Logs) Web Apr 8, 2026 at 4:29 am
mcp-hub ✅ Success (View Logs) Web Apr 8, 2026 at 4:21 am
frontend-cloud ❌ Build Failed (View Logs) Web Apr 8, 2026 at 4:21 am
frontend-inspector ❌ Build Failed (View Logs) Web Apr 8, 2026 at 4:21 am
ladle ❌ Build Failed (View Logs) Web Apr 8, 2026 at 4:20 am

@claude
Copy link
Copy Markdown

claude bot commented Apr 8, 2026

PR Review: chore: revert actor v2 hack

Small, focused revert removing a workaround that forced serverless pool actors into the v2 migration path regardless of protocol version.

Change Analysis

The early-return condition previously included an additional || for_serverless clause alongside pool.as_ref().and_then(|p| p.protocol_version).is_some(). That extra clause has been removed, so the condition now only checks whether a protocol version is present on the pool.

Serverless actors without a protocol_version set will now go through the standard allocation path instead of unconditionally migrating to v2.

Issue: Stale Comment

runtime.rs:267 still reads "or this is a serverless pool" but that clause was removed. The comment should be updated to: // Protocol version is set; migrate to actor v2

Minor Notes

  • The .as_ref() removal is correct. pool is consumed by and_then; for_serverless (bool, Copy) was already computed so no borrow issue.
  • for_serverless remains used at line 304 for ServerlessDesiredSlotsKey atomic op -- no dead code.

Summary

The change is correct. The only actionable fix is updating the comment on line 267 to remove the now-inaccurate "or this is a serverless pool" clause.

@NathanFlurry NathanFlurry mentioned this pull request Apr 8, 2026
11 tasks
@NathanFlurry NathanFlurry marked this pull request as ready for review April 8, 2026 10:37
@NathanFlurry NathanFlurry mentioned this pull request Apr 8, 2026
11 tasks
@MasterPtato MasterPtato force-pushed the 04-07-fix_fix_pool_metadata_protocol_version_refresh_rivetkit_native_ws branch from a50c388 to cf4316a Compare April 8, 2026 20:30
@MasterPtato MasterPtato force-pushed the 04-07-chore_revert_actor_v2_hack branch from 8262c65 to d758690 Compare April 8, 2026 20:30
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4586 April 8, 2026 20:30 Destroyed
Copy link
Copy Markdown
Contributor

MasterPtato commented Apr 8, 2026

Merge activity

  • Apr 8, 8:52 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 8, 9:27 PM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 8, 9:28 PM UTC: @MasterPtato merged this pull request with Graphite.

@MasterPtato MasterPtato changed the base branch from 04-07-fix_fix_pool_metadata_protocol_version_refresh_rivetkit_native_ws to graphite-base/4586 April 8, 2026 21:24
@MasterPtato MasterPtato changed the base branch from graphite-base/4586 to main April 8, 2026 21:26
@MasterPtato MasterPtato force-pushed the 04-07-chore_revert_actor_v2_hack branch from d758690 to f4f4e02 Compare April 8, 2026 21:26
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4586 April 8, 2026 21:26 Destroyed
@MasterPtato MasterPtato merged commit 5ecfb89 into main Apr 8, 2026
10 of 14 checks passed
@MasterPtato MasterPtato deleted the 04-07-chore_revert_actor_v2_hack branch April 8, 2026 21:28
@MasterPtato MasterPtato mentioned this pull request Apr 9, 2026
11 tasks
@NathanFlurry NathanFlurry mentioned this pull request Apr 9, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants