chore(epoxy): clean up kv get

[MasterPtato]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[MasterPtato]

• fix(epoxy): use vbare #4616
• fix: dont upsert for ensure if missing #4615
• fix(envoy): require runner config for ws conn #4612
• fix(pb): backport serverless fix #4611
• fix(pb): optimize actor key allocation #4610
• fix: move runner configs to epoxy #4605
• chore(epoxy): clean up kv get #4604 👈 (View in Graphite)
• fix(pb-envoy): reduce round trips for ws connection #4603
• fix(envoy-client): fix handling actor event ack #4599
• fix(envoy-client): add tls #4595 : 1 other dependent PR (#4597 )
• chore: fix driver test suite #4591
• chore: tunnel auth #4588
• chore: remove udb as a dependency of envoy-client #4587
• chore: revert actor v2 hack #4586
• fix: fix pool metadata protocol version refresh, rivetkit native ws #4585
• feat: US-001 - Define SqliteKv trait in rivetkit-sqlite-native #4584
• feat(rust/engine-runner): minimal rust engine runner #4289
• chore: delete kv channel #4583
• feat(engine): rust runner #4582
• chore: remove non-engine drivers #4574 : 1 other dependent PR (#4581 )
• feat: dynamic actors #4397
• fix: driver test suite & sqlite reliability #4559
• fix: remove serverless token #4572
• fix: misc token fixes #4569
• fix(pb): clean up actor stop decision handling #4566
• fix(envoy): use global instance, add signal handlers #4565
• chore: misc fixes, add pb snapshot test #4561
• fix(cache): make in memory cache global #4560
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review for chore(epoxy): clean up kv get

Well-executed cleanup. Summary of findings:

POSITIVE: Returning Option directly removes the Output wrapper struct. Moving read_local_value into get_local.rs improves locality. key slice parameter removes gratuitous clones. tokio::try_join! reduces worst-case latency from 3x RTT to 1x RTT. The .or() combinator usage is idiomatic.

TRADE-OFF: The old sequential code short-circuited on hit (legacy/cache reads skipped if V2 value found). The new parallel code always fires all three reads. Acceptable for a cleanup but worth revisiting after full backfill migration.

SUGGESTION: responses.first() relies on an invariant that should be a debug_assert_eq!(responses.len(), 1) rather than just a comment.

NOTE: get_optimistic.rs still has a glob import from anyhow despite CLAUDE.md recommending specific imports. This was pre-existing but the file was touched and it would have been a good opportunity to fix it.

CORRECTNESS: tokio::try_join! on shared tx references relies on tx.get taking shared self. Appears correct given the transaction API design.

VERDICT: Clean, well-scoped refactor. No functional regressions. All suggestions are minor and non-blocking.

[NathanFlurry]

remove

[MasterPtato]

Merge activity

• Apr 13, 12:21 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Apr 13, 12:32 AM UTC: Graphite rebased this pull request as part of a merge.
• Apr 13, 12:32 AM UTC: @MasterPtato merged this pull request with Graphite.