fix: dont upsert for ensure if missing

[MasterPtato]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[MasterPtato]

• fix(epoxy): use vbare #4616
• fix: dont upsert for ensure if missing #4615 👈 (View in Graphite)
• fix(envoy): require runner config for ws conn #4612
• fix(pb): backport serverless fix #4611
• fix(pb): optimize actor key allocation #4610
• fix: move runner configs to epoxy #4605
• chore(epoxy): clean up kv get #4604
• fix(pb-envoy): reduce round trips for ws connection #4603
• fix(envoy-client): fix handling actor event ack #4599
• fix(envoy-client): add tls #4595 : 1 other dependent PR (#4597 )
• chore: fix driver test suite #4591
• chore: tunnel auth #4588
• chore: remove udb as a dependency of envoy-client #4587
• chore: revert actor v2 hack #4586
• fix: fix pool metadata protocol version refresh, rivetkit native ws #4585
• feat: US-001 - Define SqliteKv trait in rivetkit-sqlite-native #4584
• feat(rust/engine-runner): minimal rust engine runner #4289
• chore: delete kv channel #4583
• feat(engine): rust runner #4582
• chore: remove non-engine drivers #4574 : 1 other dependent PR (#4581 )
• feat: dynamic actors #4397
• fix: driver test suite & sqlite reliability #4559
• fix: remove serverless token #4572
• fix: misc token fixes #4569
• fix(pb): clean up actor stop decision handling #4566
• fix(envoy): use global instance, add signal handlers #4565
• chore: misc fixes, add pb snapshot test #4561
• fix(cache): make in memory cache global #4560
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: fix: dont upsert for ensure if missing

Status: Merged — bug still present, follow-up needed.

Critical bug: inverted condition in ensure_normal_if_missing.rs

The condition on line 23 is inverted and was merged as-is:

if !pool_res.is_empty() {  // upserts when config EXISTS — wrong
    ctx.op(upsert::Input { ... }).await?;
}

pool_res holds existing runner configs returned by the get op. So !pool_res.is_empty() is true when the config is already present, meaning this function now upserts (and overwrites with defaults) when a config exists, and does nothing when it is missing. That is the opposite of what the function name and docstring promise.

The fix is a one-character change:

if pool_res.is_empty() {  // upsert only when config is missing
    ctx.op(upsert::Input { ... }).await?;
}

A follow-up PR is needed to correct this.

---

Stale doc comment

The doc comment still says "Returns true when the config was created" but the return type is Result<()>, not Result<bool>. This should be removed.

---

envoy.rs simplification — looks correct

Removing the has_actors early-exit branch is safe: join_all on an empty Vec resolves immediately, so ToEnvoyMessage::Stop is sent without delay when there are no active actors. The logic is equivalent and simpler.

handle.rs — cosmetic whitespace, no concerns.

[MasterPtato]

Merge activity

• Apr 13, 12:21 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Apr 13, 12:42 AM UTC: Graphite rebased this pull request as part of a merge.
• Apr 13, 12:42 AM UTC: @MasterPtato merged this pull request with Graphite.