Adding ability to set the dns policy and config for the runner pod

[andrewgkew]

Currently the helm chart is missing the capability to set the DNS Policy and DNS Config of the runner pod

Adding this ability. By default its turned off and defaults to ClusterFirst which is the default value for this field if this doesnt exist

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c503a2b2-03e3-4da2-a334-a2ee73004fe6

📥 Commits

Reviewing files that changed from the base of the PR and between 8d5b605 and 865bc4a.

📒 Files selected for processing (1)

• helm/robusta/values.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• helm/robusta/values.yaml

---

Walkthrough

Adds a runner.dnsConfig values block and updates the runner Pod template to render dnsPolicy from it. When runner.dnsConfig.enabled is true, a dnsConfig subsection is conditionally rendered from nameservers, searches, and options; when disabled, dnsPolicy is ClusterFirst. Helm-time validation blocks dnsPolicy: "None" with no entries.

Changes

DNS configuration for runner Pod

Layer / File(s)	Summary
Data Shape helm/robusta/values.yaml	Introduces runner.dnsConfig with fields: enabled (bool), policy (string), nameservers (list), searches (list), options (list); defaults set with enabled: false and policy: ClusterFirst.
Template Rendering helm/robusta/templates/runner.yaml	Renders dnsPolicy from runner.dnsConfig.policy. When runner.dnsConfig.enabled is true, conditionally emits a dnsConfig block populated from nameservers, searches, and options only if entries exist; otherwise omits dnsConfig.
Validation helm/robusta/templates/runner.yaml	Adds Helm-time check that prevents rendering if dnsPolicy is "None" while nameservers, searches, and options are all empty.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding DNS policy and config capability for the runner pod, which matches the changeset modifications to the Helm template and values files.
Description check	✅ Passed	The description is related to the changeset, explaining the motivation (missing DNS capability) and implementation approach (disabled by default, defaults to ClusterFirst), which aligns with the actual changes made.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@helm/robusta/templates/runner.yaml`:
- Around line 45-58: The dnsConfig block is being emitted at the wrong YAML
level: when .Values.runner.dnsConfig.enabled is true, ensure you output a
top-level dnsConfig: mapping and nest dnsPolicy, nameservers, searches, and
options under it; update the template in runner.yaml to render a single
dnsConfig: key (using .Values.runner.dnsConfig) and then conditionally render
dnsPolicy and the three child lists (nameservers, searches, options) indented
under dnsConfig so the Kubernetes Pod spec is valid.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b1d3a11c-1d53-46db-8820-11c1eaef623e

📥 Commits

Reviewing files that changed from the base of the PR and between b147fb8 and 3c551e0.

📒 Files selected for processing (2)

• helm/robusta/templates/runner.yaml
• helm/robusta/values.yaml

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@helm/robusta/templates/runner.yaml`:
- Around line 47-59: The template emits a bare `dnsConfig:` key when all
sub-lists are empty; wrap the entire dnsConfig block with a guard that checks
whether any of .Values.runner.dnsConfig.nameservers,
.Values.runner.dnsConfig.searches, or .Values.runner.dnsConfig.options are
non-empty (use an {{- if or ... }} / {{- end }} around the dnsConfig: stanza) so
dnsConfig is omitted entirely when all three are empty; reference the existing
dnsConfig:, .Values.runner.dnsConfig.nameservers,
.Values.runner.dnsConfig.searches, and .Values.runner.dnsConfig.options symbols
when implementing the guard.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: aea6b190-1f80-4075-ad73-f643cc4939d2

📥 Commits

Reviewing files that changed from the base of the PR and between 3c551e0 and 393926d.

📒 Files selected for processing (1)

• helm/robusta/templates/runner.yaml