Skip to content

Adding ability to set the dns policy and config for the runner pod #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RoiGlinik merged 4 commits into from
May 7, 2026
+33 −0
Merged

Adding ability to set the dns policy and config for the runner pod #2061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c551e0
Adding ability to set the dns policy and config for the runner pod
andrewgkew May 1, 2026
393926d
Missed off dnsConfig field
andrewgkew May 1, 2026
8d5b605
Updated default value to be that of default in k8s, ClusterFirst - al…
andrewgkew May 1, 2026
865bc4a
Merge branch 'master' into feature/helm-dns-config
andrewgkew May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions helm/robusta/templates/runner.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,32 @@ spec:
securityContext:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- if .Values.runner.dnsConfig.enabled }}
{{- $policy := .Values.runner.dnsConfig.policy }}
{{- $hasConfig := or .Values.runner.dnsConfig.nameservers .Values.runner.dnsConfig.searches .Values.runner.dnsConfig.options }}

{{- if and (eq $policy "None") (not $hasConfig) }}
{{- fail "dnsConfig: when dnsPolicy is 'None', you must set at least one of nameservers, searches, or options" }}
{{- end }}
dnsPolicy: {{ $policy | quote }}
{{- if $hasConfig }}
dnsConfig:
{{- with .Values.runner.dnsConfig.nameservers }}
nameservers:
{{- toYaml . | nindent 10 }}
{{- end }}
{{- with .Values.runner.dnsConfig.searches }}
searches:
{{- toYaml . | nindent 10 }}
{{- end }}
{{- with .Values.runner.dnsConfig.options }}
options:
{{- toYaml . | nindent 10 }}
{{- end }}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Comment thread
coderabbitai[bot] marked this conversation as resolved.
{{- end }}
{{ else }}
dnsPolicy: ClusterFirst
{{- end }}
{{- if .Values.runner.hardenedFs }}
initContainers:
- name: setup-venv
Expand Down
7 changes: 7 additions & 0 deletions helm/robusta/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,6 +756,13 @@ runner:
# Enable hardened filesystem security (read-only root filesystem with writable volume mounts)
hardenedFs: false
setKRRSecurityContext: false
#Enabled custom DNS configuration for runner
dnsConfig:
enabled: false
policy: ClusterFirst
nameservers: []
searches: []
options: []
# CRD permissions for common Kubernetes operators and tools
crdPermissions:
argo: true
Expand Down
Loading