Repository navigation
Conversation
Orthographic views were stretched sideways until a resize, because the camera was fitted to the whole view, toolbar included, instead of the canvas. Changes: - Take the aspect ratio from the canvas. - Use 1 for a canvas of zero size. Assisted-by: Claude:Opus 5.5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orthographic views came up stretched sideways by about 7% until a resize, because the camera was fitted to the whole view, toolbar included, instead of the canvas. The camera is now fitted to the canvas.
To be backported to 6.42.
Tested on master with event_demo.C, calorimeters.C and boxset.C in a headless browser. Without the fix, 8 of 10 event_demo projection views were first drawn stretched and corrected 30 ms to 1.1 s later. With the fix, all 20 projection views had their final shape from the first frame.