Skip to content

[eve7] Fit the orthographic camera to the canvas #24153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
osschar wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −2
Open

[eve7] Fit the orthographic camera to the canvas #24153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ui5/eve7/lib/GlViewerRCore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,8 +782,11 @@ sap.ui.define([
{
this.controls.setCamBaseMtx(new RC.Vector3(v1[0], v1[1], v1[2]), new RC.Vector3(v2[0], v2[1], v2[2]));
// Fit the height, or the width if that is what limits the panel.
let ey = 1.02 * Math.max(extV.y, extV.x * this.get_height() / this.get_width());
let ex = ey / this.get_height() * this.get_width();
// Measure the canvas, not the view, which also holds the toolbar.
let cw = this.canvas.width, ch = this.canvas.height;
let asp = (cw > 0 && ch > 0) ? cw / ch : 1;
let ey = 1.02 * Math.max(extV.y, extV.x / asp);
let ex = ey * asp;
this.camera._left = -ex;
this.camera._right = ex;
this.camera._top = ey;
Expand Down
Loading