[Warlock] Apply recent hotfixes and refine UA, Blackened Soul, Death's Embrace, and Implosion behavior

[millanzarreta]

This PR updates the Warlock module to apply recent hotfixes and replicate several additional in-game behaviors found through testing.

Withering Bolt and Wither

The recent hotfixes affecting Withering Bolt, Wither, and Darkglare Eye Beam have been verified in-game and implemented in SimC:

• Wither now contributes correctly to Withering Bolt scaling for Shadow Bolt, Drain Soul, Malefic Grasp, and Shadowbolt Volley.
• Wither now counts toward Darkglare Eye Beam damage scaling.
• Withering Bolt now increases Malefic Grasp damage.

Death's Embrace

Death's Embrace has also been retested in detail. Its modifier has been moved to composite_target_multiplier instead of composite_da_multiplier / composite_ta_multiplier, since it is a target-dependent modifier whose value is based on the target's current health.

The following tested behavior has been replicated in SimC:

• Malefic Grasp and its Agony, Corruption, Unstable Affliction, and Wither extra ticks benefit from Death's Embrace.
• The direct application damage of Corruption and Wither remains unaffected by Death's Embrace.
• Shadowbolt Volley remains unaffected by Death's Embrace, as expected.
• If any 4pc seed-applied Unstable Affliction stack is active, the combined UA periodic damage does not benefit from Death's Embrace until no seed-applied stacks remain (this appears to be an in-game bug).
• The UA extra tick triggered by Malefic Grasp is not affected by this bug and continues to benefit from Death's Embrace.
• Each visible UA stack counts as a normal stack for the Malefic Grasp extra tick, regardless of whether it was applied normally or by the 4pc seed effect.

Unstable Affliction interactions

Several effects triggered by Unstable Affliction have been retested for regular UA casts, 4pc seed-applied UA, and Fatal Echoes applications.

The implemented behavior is:

• Regular UA and 4pc seed-applied UA increment Wither stacks through Blackened Soul on a successful impact.
• UA periodic damage no longer triggers Blackened Soul.
• UA applied by Fatal Echoes does not increment Wither stacks.
• 4pc seed-applied UA does not consume Succulent Soul or trigger its associated consume effects.
• Regular UA and UA applied by Fatal Echoes continue to consume Succulent Soul and trigger its associated effects.
• 4pc seed-applied UA does not trigger Cull the Weak, while regular UA and Fatal Echoes applications do.
• UA applied by Fatal Echoes does not consume Shard Instability.

The interaction between Seed of Corruption, its 4pc seed-applied UA, and Shard Instability has also been refined.

Both Seed of Corruption and its seed-applied UA can consume Shard Instability, but a single SoC execution consumes at most one stack in total. If the seed-applied UA already consumed a stack, the parent SoC does not consume another one.

As with UA, if Shard Instability is gained during an already-started SoC cast, the cast benefits from the cost reduction but the SoC does not consume the buff. With the 4pc active, the subsequently applied UA may still consume it in this case.

Blackened Soul

Blackened Soul stack gains from Chaos Bolt, Shadowburn, and Unstable Affliction have been moved from cast execution to successful impacts.

This matches the observed in-game behavior and ensures that:

• Only successful impacts increment Wither.
• For projectile spells, the stack is gained after projectile travel rather than when the cast finishes.
• The primary and Havoc impacts process Blackened Soul independently on their respective targets.

Implosion and To Hell and Back

A new bug in the 12.1 patch appears to be affecting Implosion and the selection of imploded demons. In-game testing indicates that Implosion currently selects up to 6 demons from a broader pool of eligible Warlock summons before restricting the actual Implosion effect to selected Wild Imps.

As a result, other eligible demons can occupy selection slots and cause fewer than 6 Wild Imps to implode.

The exact selection appears to be influenced by spatial cell ordering, which SimC does not model. Therefore, SimC approximates the number of selected Wild Imps by randomly sampling without replacement from the eligible demon pool.

The implementation keeps two separate counts:

• selected_demons is the total number of demons selected by Implosion.
• selected_imps is the number of selected Wild Imps that actually implode.

To Hell and Back uses the number of selected demons rather than the number of Wild Imps that actually implode.

The following summons have been excluded from the Implosion candidate pool based on testing:

• Demons summoned by Dominion of Argus.
• Diabolist demons: Overlord, Mother of Chaos, and Pit Lord.
• Rampaging Demonic Soul.

The existing Wild Imp selection by remaining energy and spawn order is retained as an approximation for which individual imps are selected. In-game spatial ordering also appears to influence this, but its exact behavior is not currently known.

Selected Wild Imps were also observed to be launched for Implosion at approximately 50 ms intervals, matching the timing already implemented in SimC.

Burning Cleave

As indicated by Blizzard's recent hotfix, Burning Cleave now uses a normal circular area of effect rather than the previous narrow-arc behavior.

The temporary warlock.tyrant_antoran_armaments_target_mul option and its associated target-reduction logic have therefore been removed.