Skip to content

[Warlock] Apply recent hotfixes and refine UA, Blackened Soul, Death's Embrace, and Implosion behavior #11781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nyterage merged 1 commit into from
Aug 22, 2026
Merged

[Warlock] Apply recent hotfixes and refine UA, Blackened Soul, Death's Embrace, and Implosion behavior #11781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions engine/class_modules/warlock/sc_warlock.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,7 @@ int warlock_td_t::count_affliction_dots() const
if ( dots.corruption->is_ticking() )
count++;

// NOTE: 2026-02-17: Currently Wither is bugged and does not count
if ( !warlock.bugs && dots.wither->is_ticking() )
if ( dots.wither->is_ticking() )
count++;

if ( dots.seed_of_corruption->is_ticking() )
Expand Down Expand Up @@ -289,8 +288,7 @@ warlock_t::warlock_t( sim_t* sim, util::string_view name, race_e r )
normalize_destruction_mastery( false ),
eye_explosion_instanced_bug_cb( false ),
eye_explosion_instanced_bug_sb( false ),
eye_explosion_instanced_bug_rof( true ),
tyrant_antoran_armaments_target_mul( 1.0 )
eye_explosion_instanced_bug_rof( true )
{
cooldowns.haunt = get_cooldown( "haunt" );
cooldowns.dark_harvest = get_cooldown( "dark_harvest" );
Expand Down Expand Up @@ -629,9 +627,6 @@ std::string warlock_t::create_profile( save_e stype )
if ( !eye_explosion_instanced_bug_rof )
profile_str +=
"warlock.eye_explosion_instanced_bug_rof=" + util::to_string( as<int>( eye_explosion_instanced_bug_rof ) ) + "\n";
if ( tyrant_antoran_armaments_target_mul < 1.0 )
profile_str +=
"warlock.tyrant_antoran_armaments_target_mul=" + util::to_string( tyrant_antoran_armaments_target_mul ) + "\n";
rng_settings.for_each( [ &profile_str ]( auto& setting ) { profile_str += append_rng_option( setting ); } );
}

Expand All @@ -651,7 +646,6 @@ void warlock_t::copy_from( player_t* source )
eye_explosion_instanced_bug_cb = p->eye_explosion_instanced_bug_cb;
eye_explosion_instanced_bug_sb = p->eye_explosion_instanced_bug_sb;
eye_explosion_instanced_bug_rof = p->eye_explosion_instanced_bug_rof;
tyrant_antoran_armaments_target_mul = p->tyrant_antoran_armaments_target_mul;

rng_settings = p->rng_settings;
}
Expand Down
7 changes: 3 additions & 4 deletions engine/class_modules/warlock/sc_warlock.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ struct warlock_td_t : public actor_target_data_t
void target_demise();

int count_affliction_dots() const;
void ua_stack_applied( bool is_seed_ua );
void ua_stack_expired( bool is_seed_ua );
void ua_stack_applied( bool is_seed_ua = false );
void ua_stack_expired( bool is_seed_ua = false );
void reset_ua_stack_tracking();
double ua_calculate_damage_stacks() const;
timespan_t ua_stack_remains( int min_stacks ) const; // Time until the target has fewer than min_stacks UA stacks
Expand Down Expand Up @@ -437,7 +437,7 @@ struct warlock_t : public parse_player_effects_t
player_talent_t fatal_echoes;
player_talent_t cascading_calamity;
const spell_data_t* cascading_calamity_buff;
player_talent_t deaths_embrace; // Volatile Agony and Perpetual Unstability are unaffected by this
player_talent_t deaths_embrace;
player_talent_t hedonic_gorging;
player_talent_t sow_the_seeds;

Expand Down Expand Up @@ -1133,7 +1133,6 @@ struct warlock_t : public parse_player_effects_t
bool eye_explosion_instanced_bug_cb;
bool eye_explosion_instanced_bug_sb;
bool eye_explosion_instanced_bug_rof;
double tyrant_antoran_armaments_target_mul;

warlock_t( sim_t* sim, util::string_view name, race_e r );

Expand Down
Loading
Loading