Skip to content

Fix sidebar tab defaulting to "learn" on reference pages - #1594

Merged
LadyBluenotes merged 1 commit into
solidjs:mainfrom
amirhhashemi:fix-reference-tab
Jul 26, 2026
Merged

Fix sidebar tab defaulting to "learn" on reference pages#1594
LadyBluenotes merged 1 commit into
solidjs:mainfrom
amirhhashemi:fix-reference-tab

Conversation

@amirhhashemi

Copy link
Copy Markdown
Collaborator

The learn/reference tab indicator always defaulted to "learn", even when viewing a reference page.

The useMatch pattern was invalid: * wildcards are only allowed as the last segment of a path pattern.

Since useMatch's pattern syntax can't express "contains this segment at any depth" (wildcards can't trail more literal segments), switched to plain substring matching against useLocation().pathname. This is more resilient to future changes in the number or order of segments before /reference.

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify

netlify Bot commented Jul 26, 2026

Copy link
Copy Markdown

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit b466283
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/6a664c509b08e40008a1917e
😎 Deploy Preview https://deploy-preview-1594--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@LadyBluenotes
LadyBluenotes merged commit da1ea83 into solidjs:main Jul 26, 2026
8 checks passed
@amirhhashemi
amirhhashemi deleted the fix-reference-tab branch July 27, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Sidebar defaults to "Learn" when opening Reference pages

2 participants