Skip to content

Fix sidebar tab defaulting to "learn" on reference pages #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LadyBluenotes merged 1 commit into from
Jul 26, 2026
Merged

Fix sidebar tab defaulting to "learn" on reference pages #1594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions osmium/src/ui/layout/main-navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { createMemo, createSignal, For, Show } from "solid-js";
import { useBeforeLeave, useLocation, useMatch } from "@solidjs/router";
import { useBeforeLeave, useLocation } from "@solidjs/router";
import { Icon } from "solid-heroicons";
import { chevronDown } from "solid-heroicons/solid";
import { setIsOpen } from "./mobile-navigation";
Expand Down Expand Up @@ -89,8 +89,8 @@ function DirList(props: { items: SidebarItem[] }) {
}

export function MainNavigation(_props: MainNavigationProps) {
const isReference = useMatch(() => "*/reference/*?");

const location = useLocation();
const isReference = () => location.pathname.includes("/reference/");
const initialTab = () => (isReference() ? "reference" : "learn");

const [selectedTab, setSelectedTab] = createSignal(initialTab());
Expand Down
Loading