ci: Add zizmor to pre-commit and fix findings#1457
Merged
Conversation
This should be enforced by yamllint in the future.
Techassi
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
Techassi
changed the title
NickLarsenNZ
reviewed
Apr 8, 2026
NickLarsenNZ
approved these changes
Apr 8, 2026
Member
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
There was a problem hiding this comment.
LGTM.
Note: this will trigger rebuilds, but I think we have enough runners to deal with it. No need to wait IMO.
Techassi
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Techassi
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds zizmor to the pre-commit hooks. This is done to remove some findings about permissions, which are also reported in our SecObserve instance.
It additionally removes some redundant quotes from YAML files.
Successful test builds in CI: