Skip to content

ci: Add zizmor to pre-commit and fix findings #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Techassi merged 5 commits into from
Apr 8, 2026
Merged

ci: Add zizmor to pre-commit and fix findings #1457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
788e817
chore: Add zizmor to pre-commit and fix findings
Techassi Apr 7, 2026
22ff654
chore: Remove a few redudant quotes from YAML files
Techassi Apr 7, 2026
307b657
ci: Add contents: read permission to reusable worflow callers
Techassi Apr 7, 2026
b5c10fe
ci: Add id-token: write permission to reusable worflow callers
Techassi Apr 7, 2026
203ca06
Merge remote-tracking branch 'origin' into chore/add-zizmor-pre-commi…
Techassi Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/boil_pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ on:
- "rust/boil/**.rs"
- "Cargo.*"

permissions:
contents: read

env:
RUST_VERSION: 1.89.0

Expand All @@ -29,7 +32,6 @@ jobs:
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
persist-credentials: false
submodules: recursive

- name: Run cargo-deny
uses: EmbarkStudios/cargo-deny-action@3fd3802e88374d3fe9159b834c7714ec57d6c979 # v2.0.15
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/boil_release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,19 @@ on:
tags:
- "boil-[0-9]+.[0-9]+.[0-9]+**"

permissions: {}

env:
RUST_VERSION: 1.89.0

jobs:
create-release:
name: Create Draft Release
runs-on: ubuntu-latest
permissions:
# Write is needed to draft the release
# See https://github.com/softprops/action-gh-release/blob/153bb8e04406b158c6c84fc1615b65b24149a1fe/README.md?plain=1#L281
contents: write
steps:
- name: Checkout
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
Expand Down Expand Up @@ -44,6 +50,10 @@ jobs:
- { target: x86_64-unknown-linux-gnu, os: ubuntu-latest }
- { target: aarch64-apple-darwin, os: macos-latest }
runs-on: ${{ matrix.targets.os }}
permissions:
# Write is needed to upload artifacts to the release
# See https://github.com/softprops/action-gh-release/blob/153bb8e04406b158c6c84fc1615b65b24149a1fe/README.md?plain=1#L281
contents: write
steps:
- name: Checkout
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
Expand Down Expand Up @@ -74,6 +84,10 @@ jobs:
finish-release:
needs: [build]
runs-on: ubuntu-latest
permissions:
# Write is needed to finalize the release
# See https://github.com/softprops/action-gh-release/blob/153bb8e04406b158c6c84fc1615b65b24149a1fe/README.md?plain=1#L281
contents: write
steps:
- name: Finish Release
uses: softprops/action-gh-release@a06a81a03ee405af7f2048a818ed3f03bbf83c7b # v2.5.0
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/build_airflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ run-name: |
on:
workflow_dispatch:
schedule:
- cron: '0 0 1/2 * *' # https://crontab.guru/#0_0_1/2_*_*
- cron: 0 0 1/2 * * # https://crontab.guru/#0_0_1/2_*_*
push:
branches: [main]
tags:
Expand All @@ -22,13 +22,18 @@ on:
- .github/workflows/build_airflow.yaml
- .github/workflows/reusable_build_image.yaml

permissions: {}

jobs:
build_image:
name: Reusable Workflow
uses: ./.github/workflows/reusable_build_image.yaml
secrets:
harbor-robot-secret: ${{ secrets.HARBOR_ROBOT_SDP_GITHUB_ACTION_BUILD_SECRET }}
slack-token: ${{ secrets.SLACK_CONTAINER_IMAGE_TOKEN }}
permissions:
id-token: write
contents: read
with:
product-name: airflow
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/build_druid.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ run-name: |
on:
workflow_dispatch:
schedule:
- cron: '0 1 1/2 * *' # https://crontab.guru/#0_1_1/2_*_*
- cron: 0 1 1/2 * * # https://crontab.guru/#0_1_1/2_*_*
push:
branches: [main]
tags:
Expand All @@ -24,13 +24,18 @@ on:
- .github/workflows/build_druid.yaml
- .github/workflows/reusable_build_image.yaml

permissions: {}

jobs:
build_image:
name: Reusable Workflow
uses: ./.github/workflows/reusable_build_image.yaml
secrets:
harbor-robot-secret: ${{ secrets.HARBOR_ROBOT_SDP_GITHUB_ACTION_BUILD_SECRET }}
slack-token: ${{ secrets.SLACK_CONTAINER_IMAGE_TOKEN }}
permissions:
id-token: write
contents: read
with:
product-name: druid
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/build_hadoop.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ run-name: |
on:
workflow_dispatch:
schedule:
- cron: '0 2 1/2 * *' # https://crontab.guru/#0_2_1/2_*_*
- cron: 0 2 1/2 * * # https://crontab.guru/#0_2_1/2_*_*
push:
branches: [main]
tags:
Expand All @@ -24,13 +24,18 @@ on:
- .github/workflows/build_hadoop.yaml
- .github/workflows/reusable_build_image.yaml

permissions: {}

jobs:
build_image:
name: Reusable Workflow
uses: ./.github/workflows/reusable_build_image.yaml
secrets:
harbor-robot-secret: ${{ secrets.HARBOR_ROBOT_SDP_GITHUB_ACTION_BUILD_SECRET }}
slack-token: ${{ secrets.SLACK_CONTAINER_IMAGE_TOKEN }}
permissions:
id-token: write
contents: read
with:
product-name: hadoop
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/build_hbase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ run-name: |
on:
workflow_dispatch:
schedule:
- cron: '0 0 2/2 * *' # https://crontab.guru/#0_0_2/2_*_*
- cron: 0 0 2/2 * * # https://crontab.guru/#0_0_2/2_*_*
push:
branches: [main]
tags:
Expand All @@ -25,13 +25,18 @@ on:
- .github/workflows/build_hbase.yaml
- .github/workflows/reusable_build_image.yaml

permissions: {}

jobs:
build_image:
name: Reusable Workflow
uses: ./.github/workflows/reusable_build_image.yaml
secrets:
harbor-robot-secret: ${{ secrets.HARBOR_ROBOT_SDP_GITHUB_ACTION_BUILD_SECRET }}
slack-token: ${{ secrets.SLACK_CONTAINER_IMAGE_TOKEN }}
permissions:
id-token: write
contents: read
with:
product-name: hbase
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/build_hive.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ run-name: |
on:
workflow_dispatch:
schedule:
- cron: "0 2 2/2 * *" # https://crontab.guru/#0_2_2/2_*_*
- cron: 0 2 2/2 * * # https://crontab.guru/#0_2_2/2_*_*
push:
branches: [main]
tags:
Expand All @@ -25,13 +25,18 @@ on:
- .github/workflows/build_hive.yaml
- .github/workflows/reusable_build_image.yaml

permissions: {}

jobs:
build_image:
name: Reusable Workflow
uses: ./.github/workflows/reusable_build_image.yaml
secrets:
harbor-robot-secret: ${{ secrets.HARBOR_ROBOT_SDP_GITHUB_ACTION_BUILD_SECRET }}
slack-token: ${{ secrets.SLACK_CONTAINER_IMAGE_TOKEN }}
permissions:
id-token: write
contents: read
with:
product-name: hive
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/build_java-base.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ run-name: |
on:
workflow_dispatch:
schedule:
- cron: '0 0 1/2 * *' # https://crontab.guru/#0_0_1/2_*_*
- cron: 0 0 1/2 * * # https://crontab.guru/#0_0_1/2_*_*
push:
branches: [main]
tags:
Expand All @@ -20,13 +20,18 @@ on:
- .github/workflows/build_java-base.yaml
- .github/workflows/reusable_build_image.yaml

permissions: {}

jobs:
build_image:
name: Reusable Workflow
uses: ./.github/workflows/reusable_build_image.yaml
secrets:
harbor-robot-secret: ${{ secrets.HARBOR_ROBOT_SDP_GITHUB_ACTION_BUILD_SECRET }}
slack-token: ${{ secrets.SLACK_CONTAINER_IMAGE_TOKEN }}
permissions:
id-token: write
contents: read
with:
product-name: java-base
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/build_java-devel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ run-name: |
on:
workflow_dispatch:
schedule:
- cron: '0 1 1/2 * *' # https://crontab.guru/#0_1_1/2_*_*
- cron: 0 1 1/2 * * # https://crontab.guru/#0_1_1/2_*_*
push:
branches: [main]
tags:
Expand All @@ -20,13 +20,18 @@ on:
- .github/workflows/build_java-devel.yaml
- .github/workflows/reusable_build_image.yaml

permissions: {}

jobs:
build_image:
name: Reusable Workflow
uses: ./.github/workflows/reusable_build_image.yaml
secrets:
harbor-robot-secret: ${{ secrets.HARBOR_ROBOT_SDP_GITHUB_ACTION_BUILD_SECRET }}
slack-token: ${{ secrets.SLACK_CONTAINER_IMAGE_TOKEN }}
permissions:
id-token: write
contents: read
with:
product-name: java-devel
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/build_kafka-testing-tools.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ run-name: |
on:
workflow_dispatch:
schedule:
- cron: '0 2 1/2 * *' # https://crontab.guru/#0_2_1/2_*_*
- cron: 0 2 1/2 * * # https://crontab.guru/#0_2_1/2_*_*
push:
branches: [main]
tags:
Expand All @@ -24,13 +24,18 @@ on:
- .github/workflows/build_kafka-testing-tools.yaml
- .github/workflows/reusable_build_image.yaml

permissions: {}

jobs:
build_image:
name: Reusable Workflow
uses: ./.github/workflows/reusable_build_image.yaml
secrets:
harbor-robot-secret: ${{ secrets.HARBOR_ROBOT_SDP_GITHUB_ACTION_BUILD_SECRET }}
slack-token: ${{ secrets.SLACK_CONTAINER_IMAGE_TOKEN }}
permissions:
id-token: write
contents: read
with:
product-name: kafka-testing-tools
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/build_kafka.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ run-name: |
on:
workflow_dispatch:
schedule:
- cron: '0 0 2/2 * *' # https://crontab.guru/#0_0_2/2_*_*
- cron: 0 0 2/2 * * # https://crontab.guru/#0_0_2/2_*_*
push:
branches: [main]
tags:
Expand All @@ -25,13 +25,18 @@ on:
- .github/workflows/build_kafka.yaml
- .github/workflows/reusable_build_image.yaml

permissions: {}

jobs:
build_image:
name: Reusable Workflow
uses: ./.github/workflows/reusable_build_image.yaml
secrets:
harbor-robot-secret: ${{ secrets.HARBOR_ROBOT_SDP_GITHUB_ACTION_BUILD_SECRET }}
slack-token: ${{ secrets.SLACK_CONTAINER_IMAGE_TOKEN }}
permissions:
id-token: write
contents: read
with:
product-name: kafka
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/build_krb5.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ run-name: |
on:
workflow_dispatch:
schedule:
- cron: '0 2 2/2 * *' # https://crontab.guru/#0_2_2/2_*_*
- cron: 0 2 2/2 * * # https://crontab.guru/#0_2_2/2_*_*
push:
branches: [main]
tags:
Expand All @@ -20,13 +20,18 @@ on:
- .github/workflows/build_krb5.yaml
- .github/workflows/reusable_build_image.yaml

permissions: {}

jobs:
build_image:
name: Reusable Workflow
uses: ./.github/workflows/reusable_build_image.yaml
secrets:
harbor-robot-secret: ${{ secrets.HARBOR_ROBOT_SDP_GITHUB_ACTION_BUILD_SECRET }}
slack-token: ${{ secrets.SLACK_CONTAINER_IMAGE_TOKEN }}
permissions:
id-token: write
contents: read
with:
product-name: krb5
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/build_nifi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ run-name: |
on:
workflow_dispatch:
schedule:
- cron: "0 0 1/2 * *" # https://crontab.guru/#0_0_1/2_*_*
- cron: 0 0 1/2 * * # https://crontab.guru/#0_0_1/2_*_*
push:
branches: [main]
tags:
Expand All @@ -24,13 +24,18 @@ on:
- .github/workflows/build_nifi.yaml
- .github/workflows/reusable_build_image.yaml

permissions: {}

jobs:
build_image:
name: Reusable Workflow
uses: ./.github/workflows/reusable_build_image.yaml
secrets:
harbor-robot-secret: ${{ secrets.HARBOR_ROBOT_SDP_GITHUB_ACTION_BUILD_SECRET }}
slack-token: ${{ secrets.SLACK_CONTAINER_IMAGE_TOKEN }}
permissions:
id-token: write
contents: read
with:
product-name: nifi
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/build_omid.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ run-name: |
on:
workflow_dispatch:
schedule:
- cron: '0 1 1/2 * *' # https://crontab.guru/#0_1_1/2_*_*
- cron: 0 1 1/2 * * # https://crontab.guru/#0_1_1/2_*_*
push:
branches: [main]
tags:
Expand All @@ -24,13 +24,18 @@ on:
- .github/workflows/build_omid.yaml
- .github/workflows/reusable_build_image.yaml

permissions: {}

jobs:
build_image:
name: Reusable Workflow
uses: ./.github/workflows/reusable_build_image.yaml
secrets:
harbor-robot-secret: ${{ secrets.HARBOR_ROBOT_SDP_GITHUB_ACTION_BUILD_SECRET }}
slack-token: ${{ secrets.SLACK_CONTAINER_IMAGE_TOKEN }}
permissions:
id-token: write
contents: read
with:
product-name: omid
sdp-version: ${{ github.ref_type == 'tag' && github.ref_name || '0.0.0-dev' }}
Expand Down
Loading
Loading