add error feedback if obs64 exe is missing #1610
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* controller.cpp: Adding new exitcode that represents the obs64 exe could not be found. Updating JS code to properly check the exitCode to avoid a silent failure case * utility.hpp: Output to error stream when connection fails. Previously, the code attempted to return a JS exception but it never got to run due to the exit(1). This way we maintain legacy behavior and exit application with a helpful message * module.js: verify bin folder contains obs64
sandboxcoder
force-pushed
the
rno/check-apple-for-bin-folder-only
branch
from
a247f75 to
03f3218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Below is error feedback added if obs64 exe is missing:
controller.cpp: Adding new exit code that represents the obs64 exe could not be found. Updating JS code to properlycheck the exitCode to avoid a silent failure case
utility.hpp: Output to error stream when connection fails. Previously, the code attempted to return a JSexception but it never got to run due to the
exit(1). This way we maintain legacy behavior and exit application with a helpful messagemodule.js: verify obs64 actually exists in the bin folder (same as the checks we do forobs64.exe)Motivation and Context
Resolves a silent failure I encountered on Windows when I put a bin folder in the desktop/node_modules/obs-studio-node parent folder which caused
yarn run testto FAIL to spin up obs64 ipc server due to not being able to findbin/obs64How Has This Been Tested?
Verified desktop/tests will ignore the
binfolder if the obs64 is missing and errors will be printed when it cannot be found.Types of changes
Checklist: